Changeset 241953 in webkit

Timestamp:

Feb 22, 2019 10:46:29 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Remove unused Timeline record selection code path
​https://bugs.webkit.org/show_bug.cgi?id=194931

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-22
Reviewed by Devin Rousso.

• UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview):
(WI.TimelineOverview.prototype.userSelectedRecord): Deleted.

• UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):
(WI.TimelineRecordingContentView.prototype.timelineOverviewUserSelectedRecord): Deleted.

• UserInterface/Views/TimelineView.js:

(WI.TimelineView.prototype.userSelectedRecordFromOverview): Deleted.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineOverview.js (modified) (3 diffs)
• UserInterface/Views/TimelineRecordingContentView.js (modified) (2 diffs)
• UserInterface/Views/TimelineView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-02-22  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Remove unused Timeline record selection code path
+        https://bugs.webkit.org/show_bug.cgi?id=194931
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/TimelineOverview.js:
+        (WI.TimelineOverview):
+        (WI.TimelineOverview.prototype.userSelectedRecord): Deleted.
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WI.TimelineRecordingContentView):
+        (WI.TimelineRecordingContentView.prototype.timelineOverviewUserSelectedRecord): Deleted.
+        * UserInterface/Views/TimelineView.js:
+        (WI.TimelineView.prototype.userSelectedRecordFromOverview): Deleted.
+
 2019-02-21  Darin Adler  <darin@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js

@@ -26 +26 @@
 WI.TimelineOverview = class TimelineOverview extends WI.View
 {
-    constructor(timelineRecording, delegate)
+    constructor(timelineRecording)
     {
         super();
@@ -46 +46 @@
         this._recording.addEventListener(WI.TimelineRecording.Event.MarkerAdded, this._markerAdded, this);
         this._recording.addEventListener(WI.TimelineRecording.Event.Reset, this._recordingReset, this);
-
-        this._delegate = delegate;
 
         this.element.classList.add("timeline-overview");
@@ -410 +408 @@
 
         overviewGraph.selectedRecord = record;
-    }
-
-    userSelectedRecord(record)
-    {
-        if (this._delegate && this._delegate.timelineOverviewUserSelectedRecord)
-            this._delegate.timelineOverviewUserSelectedRecord(this, record);
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js

@@ -35 +35 @@
         this.element.classList.add("timeline-recording");
 
-        this._timelineOverview = new WI.TimelineOverview(this._recording, this);
+        this._timelineOverview = new WI.TimelineOverview(this._recording);
         this._timelineOverview.addEventListener(WI.TimelineOverview.Event.TimeRangeSelectionChanged, this._timeRangeSelectionChanged, this);
         this._timelineOverview.addEventListener(WI.TimelineOverview.Event.RecordSelected, this._recordSelected, this);
@@ -261 +261 @@
         const hasChildren = false;
         return new WI.GeneralTreeElement(iconClassName, title, representedObject, hasChildren);
-    }
-
-    // TimelineOverview delegate
-
-    timelineOverviewUserSelectedRecord(timelineOverview, timelineRecord)
-    {
-        let timelineViewForRecord = null;
-        for (let timelineView of this._timelineViewMap.values()) {
-            if (timelineView.representedObject.type === timelineRecord.type) {
-                timelineViewForRecord = timelineView;
-                break;
-            }
-        }
-
-        if (!timelineViewForRecord)
-            return;
-
-        this._timelineContentBrowser.showContentView(timelineViewForRecord);
-        timelineViewForRecord.userSelectedRecordFromOverview(timelineRecord);
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js

@@ -296 +296 @@
     // Protected
 
-    userSelectedRecordFromOverview(timelineRecord)
-    {
-        // Implemented by sub-classes if needed.
-    }
-
     filterDidChange()
     {