Changeset 241970 in webkit

Timestamp:

Feb 22, 2019 4:41:58 PM (5 years ago)

Author:

aestes@apple.com

Message:

[iOS] Break a reference cycle between PreviewLoader and ResourceLoader
​https://bugs.webkit.org/show_bug.cgi?id=194964
<rdar://problem/48279441>

Reviewed by Alex Christensen.

When a document's QuickLook preview is loaded, a reference cycle is created between
PreviewLoader and ResourceLoader. Break the cycle by clearing m_previewLoader in
ResourceLoader::releaseResources().

Fixes leaks detected by run-webkit-tests --leaks LayoutTests/quicklook.

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::releaseResources):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/ResourceLoader.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-02-22  Andy Estes  <aestes@apple.com>
+
+        [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
+        https://bugs.webkit.org/show_bug.cgi?id=194964
+        <rdar://problem/48279441>
+
+        Reviewed by Alex Christensen.
+
+        When a document's QuickLook preview is loaded, a reference cycle is created between
+        PreviewLoader and ResourceLoader. Break the cycle by clearing m_previewLoader in
+        ResourceLoader::releaseResources().
+
+        Fixes leaks detected by `run-webkit-tests --leaks LayoutTests/quicklook`.
+
+        * loader/ResourceLoader.cpp:
+        (WebCore::ResourceLoader::releaseResources):
+
 2019-02-22  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/loader/ResourceLoader.cpp

@@ -114 +114 @@
     m_resourceData = nullptr;
     m_deferredRequest = ResourceRequest();
+
+#if USE(QUICK_LOOK)
+    m_previewLoader = nullptr;
+#endif
 }