Changeset 242010 in webkit
- Timestamp:
- Feb 23, 2019 7:03:10 PM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r241997 r242010 1 2019-02-23 Chris Dumez <cdumez@apple.com> 2 3 Give DrawingAreas their own identifiers 4 https://bugs.webkit.org/show_bug.cgi?id=194969 5 <rdar://problem/48154508> 6 7 Unreviewed, fix API test debug assertion failures after r241988. 8 We do not support sending an ObjectIdentifier that is 0 via IPC so update WebPageProxy::CreateNewPage 9 IPC to return an Optional<WebPageCreationParameters> instead of a WebPageCreationParameters. It returns 10 nullopt when there this no UIClient or the client did not create the page, instead of returning a 11 default-initialized WebPageCreationParameters. 12 13 * UIProcess/WebPageProxy.cpp: 14 (WebKit::WebPageProxy::createNewPage): 15 * UIProcess/WebPageProxy.messages.in: 16 * WebProcess/WebCoreSupport/WebChromeClient.cpp: 17 (WebKit::WebChromeClient::createWindow): 18 1 19 2019-02-23 Simon Fraser <simon.fraser@apple.com> 2 20 -
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
r241988 r242010 4873 4873 m_uiClient->createNewPage(*this, WTFMove(originatingFrameInfo), WTFMove(request), WTFMove(windowFeatures), WTFMove(navigationActionData), [this, protectedThis = makeRef(*this), mainFrameURL, request, reply = WTFMove(reply)] (RefPtr<WebPageProxy> newPage) mutable { 4874 4874 if (!newPage) { 4875 reply(0, { });4875 reply(0, WTF::nullopt); 4876 4876 return; 4877 4877 } -
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
r241321 r242010 23 23 messages -> WebPageProxy { 24 24 # UI messages 25 CreateNewPage(struct WebKit::FrameInfoData originatingFrameInfoData, uint64_t originatingPageID, WebCore::ResourceRequest request, struct WebCore::WindowFeatures windowFeatures, struct WebKit::NavigationActionData navigationActionData) -> (uint64_t newPageID, struct WebKit::WebPageCreationParametersnewPageParameters) Delayed25 CreateNewPage(struct WebKit::FrameInfoData originatingFrameInfoData, uint64_t originatingPageID, WebCore::ResourceRequest request, struct WebCore::WindowFeatures windowFeatures, struct WebKit::NavigationActionData navigationActionData) -> (uint64_t newPageID, Optional<WebKit::WebPageCreationParameters> newPageParameters) Delayed 26 26 ShowPage() 27 27 ClosePage(bool stopResponsivenessTimer) -
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
r241321 r242010 286 286 287 287 uint64_t newPageID = 0; 288 WebPageCreationParametersparameters;288 Optional<WebPageCreationParameters> parameters; 289 289 if (!webProcess.parentProcessConnection()->sendSync(Messages::WebPageProxy::CreateNewPage(webFrame->info(), webFrame->page()->pageID(), request.resourceRequest(), windowFeatures, navigationActionData), Messages::WebPageProxy::CreateNewPage::Reply(newPageID, parameters), m_page.pageID())) 290 290 return nullptr; … … 292 292 if (!newPageID) 293 293 return nullptr; 294 295 webProcess.createWebPage(newPageID, WTFMove(parameters)); 294 ASSERT(parameters); 295 296 webProcess.createWebPage(newPageID, WTFMove(*parameters)); 296 297 return webProcess.webPage(newPageID)->corePage(); 297 298 }
Note: See TracChangeset
for help on using the changeset viewer.