Changeset 242034 in webkit

Timestamp:

Feb 25, 2019 2:11:57 AM (5 years ago)

Author:

aboya@igalia.com

Message:

[MSE][GStreamer] Batch player duration updates
​https://bugs.webkit.org/show_bug.cgi?id=194220

Reviewed by Xabier Rodriguez-Calvar.

This saves up a ton of CPU cycles doing layout unnecessarily when all
the appended frames extend the duration of the movie, like in
YTTV 2018 59.DASHLatencyVP9.

This patch is an optimization that introduces no new behavior.

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::consumeAppsinkAvailableSamples):

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::blockDurationChanges):
(WebCore::MediaPlayerPrivateGStreamerMSE::unblockDurationChanges):
(WebCore::MediaPlayerPrivateGStreamerMSE::durationChanged):

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/mse/AppendPipeline.cpp (modified) (1 diff)
• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp (modified) (2 diffs)
• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-02-25  Alicia Boya García  <aboya@igalia.com>
+
+        [MSE][GStreamer] Batch player duration updates
+        https://bugs.webkit.org/show_bug.cgi?id=194220
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        This saves up a ton of CPU cycles doing layout unnecessarily when all
+        the appended frames extend the duration of the movie, like in
+        YTTV 2018 59.DASHLatencyVP9.
+
+        This patch is an optimization that introduces no new behavior.
+
+        * platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+        (WebCore::AppendPipeline::consumeAppsinkAvailableSamples):
+        * platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
+        (WebCore::MediaPlayerPrivateGStreamerMSE::blockDurationChanges):
+        (WebCore::MediaPlayerPrivateGStreamerMSE::unblockDurationChanges):
+        (WebCore::MediaPlayerPrivateGStreamerMSE::durationChanged):
+        * platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
+
 2019-02-25  Miguel Gomez  <magomez@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp

@@ -513 +513 @@
     GRefPtr<GstSample> sample;
     int batchedSampleCount = 0;
+    // In some cases each frame increases the duration of the movie.
+    // Batch duration changes so that if we pick 100 of such samples we don't have to run 100 times
+    // layout for the video controls, but only once.
+    m_playerPrivate->blockDurationChanges();
     while ((sample = adoptGRef(gst_app_sink_try_pull_sample(GST_APP_SINK(m_appsink.get()), 0)))) {
         appsinkNewSample(WTFMove(sample));
         batchedSampleCount++;
     }
+    m_playerPrivate->unblockDurationChanges();
 
     GST_TRACE_OBJECT(m_pipeline.get(), "batchedSampleCount = %d", batchedSampleCount);

trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp

@@ -662 +662 @@
 }
 
+void MediaPlayerPrivateGStreamerMSE::blockDurationChanges()
+{
+    ASSERT(isMainThread());
+    m_areDurationChangesBlocked = true;
+    m_shouldReportDurationWhenUnblocking = false;
+}
+
+void MediaPlayerPrivateGStreamerMSE::unblockDurationChanges()
+{
+    ASSERT(isMainThread());
+    if (m_shouldReportDurationWhenUnblocking) {
+        m_player->durationChanged();
+        m_playbackPipeline->notifyDurationChanged();
+        m_shouldReportDurationWhenUnblocking = false;
+    }
+
+    m_areDurationChangesBlocked = false;
+}
+
 void MediaPlayerPrivateGStreamerMSE::durationChanged()
 {
+    ASSERT(isMainThread());
     if (!m_mediaSourceClient) {
         GST_DEBUG("m_mediaSourceClient is null, doing nothing");
@@ -677 +697 @@
     // by the HTMLMediaElement.
     if (m_mediaTimeDuration != previousDuration && m_mediaTimeDuration.isValid() && previousDuration.isValid()) {
-        m_player->durationChanged();
-        m_playbackPipeline->notifyDurationChanged();
+        if (!m_areDurationChangesBlocked) {
+            m_player->durationChanged();
+            m_playbackPipeline->notifyDurationChanged();
+        } else
+            m_shouldReportDurationWhenUnblocking = true;
         m_mediaSource->durationChanged(m_mediaTimeDuration);
     }

trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h

@@ -83 +83 @@
     void notifySeekNeedsDataForTime(const MediaTime&);
 
+    void blockDurationChanges();
+    void unblockDurationChanges();
+
 private:
     static void getSupportedTypes(HashSet<String, ASCIICaseInsensitiveHash>&);
@@ -112 +115 @@
     MediaTime m_mediaTimeDuration;
     bool m_mseSeekCompleted = true;
+    bool m_areDurationChangesBlocked = false;
+    bool m_shouldReportDurationWhenUnblocking = false;
     RefPtr<PlaybackPipeline> m_playbackPipeline;
 };