Changeset 242057 in webkit

Timestamp:

Feb 25, 2019 2:22:56 PM (5 years ago)

Author:

Matt Baker

Message:

Web Inspector: REGRESSION: TreeElement or Table row selected using the keyboard should always be revealed
​https://bugs.webkit.org/show_bug.cgi?id=194918
<rdar://problem/48289314>

Reviewed by Devin Rousso.

• UserInterface/Views/Table.js:

(WI.Table.prototype.selectionControllerSelectionDidChange):

• UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype._treeKeyDown):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/Table.js (modified) (1 diff)
• UserInterface/Views/TreeOutline.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-02-25  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: REGRESSION: TreeElement or Table row selected using the keyboard should always be revealed
+        https://bugs.webkit.org/show_bug.cgi?id=194918
+        <rdar://problem/48289314>
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/Table.js:
+        (WI.Table.prototype.selectionControllerSelectionDidChange):
+
+        * UserInterface/Views/TreeOutline.js:
+        (WI.TreeOutline.prototype._treeKeyDown):
+
 2019-02-25  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/Table.js

@@ -620 +620 @@
         }
 
-        if (selectedItems.size === 1) {
-            let rowIndex = this._indexForRepresentedObject(selectedItems.firstValue);
-            if (!this._isRowVisible(rowIndex))
-                this.revealRow(rowIndex);
+        if (this._selectionController.lastSelectedItem) {
+            let rowIndex = this._indexForRepresentedObject(this._selectionController.lastSelectedItem);
+            this.revealRow(rowIndex);
         }
 

trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

@@ -662 +662 @@
             handled = this._selectionController.handleKeyDown(event);
             this._itemWasSelectedByUser = false;
+
+            if (handled)
+                nextSelectedElement = this.selectedTreeElement;
         }