Changeset 242084 in webkit

Timestamp:

Feb 26, 2019 7:11:29 AM (5 years ago)

Author:

Philippe Normand

Message:

[EGL] Runtime support for RGB565 pixel layout
​https://bugs.webkit.org/show_bug.cgi?id=194817

Reviewed by Carlos Garcia Campos.

Currently our graphics pipeline always relies on a ARGB8888 (32
bpp) pixel configuration. On some low-end (old) embedded platforms
the graphics driver is sometimes optimized for 16 bpp
configurations, such as RGB565. On those platforms the application
can now set the WEBKIT_EGL_PIXEL_LAYOUT environment variable to
"RGB565" to adjust to the best pixel configuration supported by
the screen and graphics driver.

• platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::getEGLConfig):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/egl/GLContextEGL.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-02-26  Philippe Normand  <pnormand@igalia.com>
+
+        [EGL] Runtime support for RGB565 pixel layout
+        https://bugs.webkit.org/show_bug.cgi?id=194817
+
+        Reviewed by Carlos Garcia Campos.
+
+        Currently our graphics pipeline always relies on a ARGB8888 (32
+        bpp) pixel configuration. On some low-end (old) embedded platforms
+        the graphics driver is sometimes optimized for 16 bpp
+        configurations, such as RGB565. On those platforms the application
+        can now set the WEBKIT_EGL_PIXEL_LAYOUT environment variable to
+        "RGB565" to adjust to the best pixel configuration supported by
+        the screen and graphics driver.
+
+        * platform/graphics/egl/GLContextEGL.cpp:
+        (WebCore::GLContextEGL::getEGLConfig):
+
 2019-02-26  Philippe Normand  <pnormand@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp

@@ -53 +53 @@
 #include <cairo-gl.h>
 #endif
+
+#include <wtf/Vector.h>
 
 namespace WebCore {
@@ -101 +103 @@
         EGL_RENDERABLE_TYPE, EGL_OPENGL_BIT,
 #endif
-        EGL_RED_SIZE, 8,
-        EGL_GREEN_SIZE, 8,
-        EGL_BLUE_SIZE, 8,
+        EGL_RED_SIZE, 1,
+        EGL_GREEN_SIZE, 1,
+        EGL_BLUE_SIZE, 1,
+        EGL_ALPHA_SIZE, 1,
         EGL_STENCIL_SIZE, 8,
-        EGL_ALPHA_SIZE, 8,
         EGL_SURFACE_TYPE, EGL_NONE,
         EGL_NONE
     };
+
+    bool isRGB565 = false;
+    if (const char* environmentVariable = getenv("WEBKIT_EGL_PIXEL_LAYOUT")) {
+        if (!strcmp(environmentVariable, "RGB565")) {
+            isRGB565 = true;
+            // EGL_RED_SIZE
+            attributeList[3] = 5;
+            // EGL_GREEN_SIZE
+            attributeList[5] = 6;
+            // EGL_BLUE_SIZE
+            attributeList[7] = 5;
+            // EGL_ALPHA_SIZE
+            attributeList[9] = 0;
+        } else
+            WTFLogAlways("Unknown pixel layout %s, falling back to RGBA8888", environmentVariable);
+    }
 
     switch (surfaceType) {
@@ -123 +141 @@
     }
 
+    EGLint count;
+    if (!eglChooseConfig(display, attributeList, nullptr, 0, &count))
+        return false;
+
     EGLint numberConfigsReturned;
-    return eglChooseConfig(display, attributeList, config, 1, &numberConfigsReturned) && numberConfigsReturned;
+    Vector<EGLConfig> configs(count);
+    if (!eglChooseConfig(display, attributeList, isRGB565 ? reinterpret_cast<EGLConfig*>(configs.data()) : config, isRGB565 ? count : 1, &numberConfigsReturned) || !numberConfigsReturned)
+        return false;
+
+    if (!isRGB565)
+        return true;
+
+    auto index = configs.findMatching([&](EGLConfig value) {
+        EGLint redSize, greenSize, blueSize, alphaSize;
+        eglGetConfigAttrib(display, value, EGL_RED_SIZE, &redSize);
+        eglGetConfigAttrib(display, value, EGL_GREEN_SIZE, &greenSize);
+        eglGetConfigAttrib(display, value, EGL_BLUE_SIZE, &blueSize);
+        eglGetConfigAttrib(display, value, EGL_ALPHA_SIZE, &alphaSize);
+        return (redSize == 5 && greenSize == 6 && blueSize == 5 && !alphaSize);
+    });
+
+    if (index != notFound) {
+        *config = configs[index];
+        return true;
+    }
+    return false;
 }