Changeset 242092 in webkit
- Timestamp:
- Feb 26, 2019 10:24:41 AM (5 years ago)
- Location:
- trunk
- Files:
-
- 8 added
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r242090 r242092 1 2019-02-26 Takashi Komori <Takashi.Komori@sony.com> 2 3 [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled. 4 https://bugs.webkit.org/show_bug.cgi?id=191652 5 6 Reviewed by Alex Christensen. 7 8 Added appropriate expected results for WebKit/WebKitLegacy of WinCairo port. 9 10 * platform/wincairo-wk1/http/tests/security/401-logout/401-logout-expected.txt: Added. 11 * platform/wincairo/TestExpectations: 12 * platform/wincairo/http/tests/security/401-logout/401-logout-expected.txt: Added. 13 1 14 2019-02-26 Frederic Wang <fwang@igalia.com> 2 15 -
trunk/LayoutTests/platform/wincairo/TestExpectations
r241979 r242092 931 931 http/tests/preload [ Skip ] 932 932 http/tests/quicklook [ Skip ] 933 933 934 http/tests/security [ Skip ] 935 http/tests/security/401-logout/401-logout.php [ Pass ] 936 934 937 http/tests/ssl [ Skip ] 935 938 -
trunk/Source/WebKit/ChangeLog
r242089 r242092 1 2019-02-26 Takashi Komori <Takashi.Komori@sony.com> 2 3 [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled. 4 https://bugs.webkit.org/show_bug.cgi?id=191652 5 6 Reviewed by Alex Christensen. 7 8 Test: http/tests/security/401-logout/401-logout.php 9 10 * NetworkProcess/curl/NetworkDataTaskCurl.cpp: 11 (WebKit::NetworkDataTaskCurl::tryHttpAuthentication): 12 (WebKit::NetworkDataTaskCurl::tryProxyAuthentication): 13 * NetworkProcess/curl/NetworkDataTaskCurl.h: 14 1 15 2019-02-26 Youenn Fablet <youenn@apple.com> 2 16 -
trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp
r241317 r242092 360 360 } 361 361 362 if (disposition == AuthenticationChallengeDisposition::UseCredential && (!credential.isEmpty() || !m_didChallengeEmptyCredentialForAuth)) { 363 // When "isAllowedToAskUserForCredentials" is false, an empty credential, which might cause 364 // an infinite authentication loop. To avoid such infinite loop, a HTTP authentication with empty 365 // user and password is processed only once. 366 if (credential.isEmpty()) 367 m_didChallengeEmptyCredentialForAuth = true; 368 362 if (disposition == AuthenticationChallengeDisposition::UseCredential && !credential.isEmpty()) { 369 363 if (m_storedCredentialsPolicy == StoredCredentialsPolicy::Use) { 370 364 if (credential.persistence() == CredentialPersistenceForSession || credential.persistence() == CredentialPersistencePermanent) … … 392 386 } 393 387 394 if (disposition == AuthenticationChallengeDisposition::UseCredential && (!credential.isEmpty() || !m_didChallengeEmptyCredentialForProxyAuth)) { 395 if (credential.isEmpty()) 396 m_didChallengeEmptyCredentialForProxyAuth = true; 397 388 if (disposition == AuthenticationChallengeDisposition::UseCredential && !credential.isEmpty()) { 398 389 CurlContext::singleton().setProxyUserPass(credential.user(), credential.password()); 399 390 CurlContext::singleton().setDefaultProxyAuthMethod(); -
trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.h
r241317 r242092 88 88 unsigned m_redirectCount { 0 }; 89 89 unsigned m_authFailureCount { 0 }; 90 bool m_didChallengeEmptyCredentialForAuth { false };91 bool m_didChallengeEmptyCredentialForProxyAuth { false };92 90 MonotonicTime m_startTime; 93 91 }; -
trunk/Tools/ChangeLog
r242089 r242092 1 2019-02-26 Takashi Komori <Takashi.Komori@sony.com> 2 3 [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled. 4 https://bugs.webkit.org/show_bug.cgi?id=191652 5 6 Reviewed by Alex Christensen. 7 8 Fix WinCairo MiniBrowser behavior of authentication dialog. 9 10 * MiniBrowser/win/WebKitBrowserWindow.cpp: 11 (WebKitBrowserWindow::didReceiveAuthenticationChallenge): 12 1 13 2019-02-26 Youenn Fablet <youenn@apple.com> 2 14 -
trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp
r239666 r242092 290 290 } 291 291 292 WKAuthenticationDecisionListener Cancel(decisionListener);293 } 292 WKAuthenticationDecisionListenerUseCredential(decisionListener, nullptr); 293 }
Note: See TracChangeset
for help on using the changeset viewer.