Changeset 242115 in webkit

Timestamp:

Feb 26, 2019 4:36:36 PM (5 years ago)

Author:

Alan Bujtas

Message:

Do not try to observe the timer when Page is nullptr
​https://bugs.webkit.org/show_bug.cgi?id=195076

Reviewed by Tim Horton.

Covered by fast/dom/Window/timer-null-script-execution-context.html.

• page/DOMTimer.cpp:

(WebCore::DOMTimer::install):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DOMTimer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-02-26  Zalan Bujtas  <zalan@apple.com>
+
+        Do not try to observe the timer when Page is nullptr
+        https://bugs.webkit.org/show_bug.cgi?id=195076
+
+        Reviewed by Tim Horton.
+
+        Covered by fast/dom/Window/timer-null-script-execution-context.html.
+
+        * page/DOMTimer.cpp:
+        (WebCore::DOMTimer::install):
+
 2019-02-20  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/page/DOMTimer.cpp

@@ -223 +223 @@
         nestedTimers->add(timer->m_timeoutId, *timer);
 #if PLATFORM(IOS_FAMILY)
-    if (is<Document>(context))
+    if (is<Document>(context) && downcast<Document>(context).page())
         downcast<Document>(context).page()->contentChangeObserver().didInstallDOMTimer(*timer, timeout, singleShot);
 #endif