Context Navigation

Changeset 242130 in webkit

Timestamp:

Feb 27, 2019, 9:33:44 AM (6 years ago)

Author:

Simon Fraser

Message:

scrolling/ios/hit-testing-iframe* tests need to hide the tap highlight
https://bugs.webkit.org/show_bug.cgi?id=195099

Reviewed by Frederic Wang.

These tests were failing because the ref test captured the tap highlight, so hide
it with -webkit-tap-highlight-color: transparent;

Location:

trunk/LayoutTests

Files:

-              r242129
+              r242130
+-02-27  Simon Fraser  <simon.fraser@apple.com>
+        scrolling/ios/hit-testing-iframe* tests need to hide the tap highlight
+        https://bugs.webkit.org/show_bug.cgi?id=195099
+        Reviewed by Frederic Wang.
+        These tests were failing because the ref test captured the tap highlight, so hide
+        it with -webkit-tap-highlight-color: transparent;
+        * fast/scrolling/ios/hit-testing-iframe-001.html:
+        * fast/scrolling/ios/hit-testing-iframe-002.html:
+        * fast/scrolling/ios/hit-testing-iframe-003.html:
+        * fast/scrolling/ios/hit-testing-iframe-004.html:
+        * fast/scrolling/ios/hit-testing-iframe-005.html:
+        * fast/scrolling/ios/hit-testing-iframe-006.html:
+        * fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html:
+        * platform/ios-wk2/TestExpectations: hit-testing-iframe-006.html passes now.
 -02-27  Ulrich Pflueger  <up@nanocosmos.de>

-              r242052
+              r242130
     <div style="position: absolute; top: 3em; width: 100px; height: 100px; background: green;">
       <iframe id="clickInContentBox" style="left: 0px; top: 0px;" scrolling="yes" onclick="this.style.background='red'" srcdoc="
           <body style='margin: 0; width: 200px; height: 200px'>
               <div style='position: absolute; width: 100px; height: 100px; background: red;'
+          <body style='margin: 0; width: 200px; height: 200px;'>
+              <div style='position: absolute; width: 100px; height: 100px; background: red; -webkit-tap-highlight-color: transparent;'
                    onclick='this.style.background=&quot;green&quot;'></div>
           </body>" onload="runTest()">

r242052	r242130
38	38	<iframe id="clickInPaddingBoxOutOfContentBox" style="left: 0px; top: 0px; background: red;" onclick="this.style.background='green'" scrolling="yes" srcdoc="
39	39	<body style='margin: 0; width: 200px; height: 200px'>
40		<div style='position: absolute; width: 100px; height: 100px; background: green;'
	40	<div style='position: absolute; width: 100px; height: 100px; background: green; -webkit-tap-highlight-color: transparent;'
41	41	onclick='this.style.background="red"'></div>
42	42	</body>" onload="runTest()">

r242052	r242130
38	38	<iframe id="clickElementAboveFrame" style="left: 0px; top: 0px;" scrolling="yes" onclick="this.style.background='red'" srcdoc="
39	39	<body style='margin: 0; width: 200px; height: 200px; background: green;'>
40		<div style='position: absolute; width: 100px; height: 100px; background: green;'
	40	<div style='position: absolute; width: 100px; height: 100px; background: green; -webkit-tap-highlight-color: transparent;'
41	41	onclick='this.style.background="red"'></div>
42	42	</body>" onload="runTest()">

r242052	r242130
38	38	<iframe id="clickElementInsideFrame" style="left: 0px; top: 0px;" scrolling="yes" onclick="this.style.background='red'" srcdoc="
39	39	<body style='margin: 0; width: 200px; height: 200px; background: green;'>
40		<div style='position: absolute; left: 10px; top: 10px; width: 50px; height: 50px; background: red;'
	40	<div style='position: absolute; left: 10px; top: 10px; width: 50px; height: 50px; background: red; -webkit-tap-highlight-color: transparent;'
41	41	onclick='this.style.background="green"'></div>
42	42	</body>" onload="runTest()">

r242052	r242130
41	41	<body style='margin: 0; width: 200px; height: 200px; background: green;'>
42	42	<div style='position: absolute; width: 75px; height: 75px; background: red;'></div>
43		<div style='position: absolute; left: 110px; top: 110px; width: 50px; height: 50px; background: red;'
	43	<div style='position: absolute; left: 110px; top: 110px; width: 50px; height: 50px; background: red; -webkit-tap-highlight-color: transparent;'
44	44	onclick='this.style.background="green"'></div>
45	45	</body>" onload="runTest()">

r242052	r242130
49	49	<body style='margin: 0; width: 200px; height: 200px; background: green;'>
50	50	<div style='position: absolute; width: 75px; height: 75px; background: red;'></div>
51		<div style='position: absolute; left: 0px; top: 150px; width: 50px; height: 50px; background: red;'
	51	<div style='position: absolute; left: 0px; top: 150px; width: 50px; height: 50px; background: red; -webkit-tap-highlight-color: transparent;'
52	52	onclick='this.style.background="green"'></div>
53	53	</body>" onload="runTest()">

r242046	r242130
58	58	<iframe id="programmaticYAndUserXAndHitTesting" style="left: 0px; top: 0px;" scrolling="yes" srcdoc="
59	59	<body style='margin: 0; width: 200px; height: 200px'>
60		<div style='left: 100px; top: 100px; position: absolute; width: 100px; height: 100px; background: red;' onclick='this.style.background="green"'></div>
	60	<div style='left: 100px; top: 100px; position: absolute; width: 100px; height: 100px; background: red; -webkit-tap-highlight-color: transparent;' onclick='this.style.background="green"'></div>
61	61	</body>" onload="runTest()">
62	62	</iframe>

r242052	r242130
1076	1076
1077	1077	fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html [ Pass Failure ]
1078		~~webkit.org/b/193997 fast/scrolling/ios/hit-testing-iframe-006.html [ ImageOnlyFailure ]~~
1079	1078
1080	1079	webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]

Note: See TracChangeset for help on using the changeset viewer.