Changeset 242231 in webkit

Timestamp:

Feb 28, 2019 2:54:38 PM (5 years ago)

Author:

Devin Rousso

Message:

REGRESSION (r240644): Layout Test inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=194437
<rdar://problem/48008005>

Reviewed by Joseph Pecoraro.

• inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
• inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:

Make sure to close the peer connection and data channel after each phase of the test.
Also add failure logging.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt (modified) (1 diff)
• inspector/page/overrideSetting-ICECandidateFilteringEnabled.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-02-28  Devin Rousso  <drousso@apple.com>
+
+        REGRESSION (r240644): Layout Test inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=194437
+        <rdar://problem/48008005>
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
+        * inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:
+        Make sure to close the peer connection and data channel after each phase of the test.
+        Also add failure logging.
+
 2019-02-28  Devin Rousso  <drousso@apple.com>
 

trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt

@@ -4 +4 @@
 == Running test suite: Page.overrideSetting
 -- Running test case: Page.overrideSetting.ICECandidateFilteringEnabled
+PASS: created offer
 PASS: Should not be able to establish a connection when filtering ice candidates.
 Overriding ICECandidateFilteringEnabled to false...
+PASS: created offer
+PASS: received ICE candidate.
 PASS: Should be able to establish a connection when filtering ice candidates.
 Removing ICECandidateFilteringEnabled override...
+PASS: created offer
 PASS: Should not be able to establish a connection when filtering ice candidates.
 

trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html

@@ -11 +11 @@
     let receivedCandidate = false;
 
+    let dc = null;
+
     let pc = new RTCPeerConnection();
-    pc.createDataChannel("sendDataChannel");
     pc.onicecandidate = (event) => {
         if (event.candidate) {
+            if (!receivedCandidate)
+                TestPage.addResult("PASS: received ICE candidate.");
             receivedCandidate = true;
             return;
         }
 
+        delete pc.onicecandidate;
+        pc.close();
+        dc.close();
+
         if (receivedCandidate) {
-            pc.createOffer().then((offer) => {
-                TestPage.dispatchEventToFrontend("DataChannel", {success: true});
-            });
+            TestPage.dispatchEventToFrontend("DataChannel", {success: true});
         } else
             TestPage.dispatchEventToFrontend("DataChannel", {success: false});
+    };
 
-        delete pc.onicecandidate;
-    };
-    pc.createOffer().then((offer) => {
-        pc.setLocalDescription(offer);
+    dc = pc.createDataChannel("sendDataChannel");
+
+    pc.createOffer()
+    .then((offer) => {
+        TestPage.addResult("PASS: created offer");
+        return pc.setLocalDescription(offer);
+    })
+    .catch((error) => {
+        TestPage.addResult("FAIL: " + error);
     });
 }