Changeset 242243 in webkit
- Timestamp:
- Feb 28, 2019 4:48:07 PM (5 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r242242 r242243 1 2019-02-28 Joseph Pecoraro <pecoraro@apple.com> 2 3 Web Inspector: CPU Usage: Worker thread that dies might stay at a high value forever 4 https://bugs.webkit.org/show_bug.cgi?id=195148 5 6 Reviewed by Matt Baker. 7 8 * UserInterface/Views/CPUTimelineView.js: 9 (CPUTimelineView.prototype.layout): 10 Handle workers dieing or at least zeroing out between records. 11 1 12 2019-02-28 Joseph Pecoraro <pecoraro@apple.com> 2 13 -
trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js
r242242 r242243 302 302 let dataPoints = []; 303 303 let workersDataMap = new Map; 304 let workersSeenInCurrentRecord = new Set; 304 305 305 306 let max = -Infinity; … … 362 363 unknownThreadAverage += unknownThreadUsage; 363 364 365 let workersSeenInLastRecord = workersSeenInCurrentRecord; 366 workersSeenInCurrentRecord = new Set; 367 364 368 if (record.workersData && record.workersData.length) { 365 369 for (let {targetId, usage} of record.workersData) { 370 workersSeenInCurrentRecord.add(targetId); 366 371 let workerData = workersDataMap.get(targetId); 367 372 if (!workerData) { … … 401 406 workerData.min = Math.min(workerData.min, usage); 402 407 workerData.average += usage; 408 } 409 } 410 411 // Close any worker that died by dropping to zero. 412 if (workersSeenInLastRecord.size) { 413 let deadWorkers = workersSeenInLastRecord.difference(workersSeenInCurrentRecord); 414 for (let workerId of deadWorkers) { 415 let workerData = workersDataMap.get(workerId); 416 if (workerData.dataPoints.lastValue.usage !== 0) 417 workerData.dataPoints.push({time, usage: 0}); 403 418 } 404 419 }
Note: See TracChangeset
for help on using the changeset viewer.