Changeset 242510 in webkit


Ignore:
Timestamp:
Mar 5, 2019 2:00:57 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Attempting to select records in the bottom 16px of the timeline overview graph fails
https://bugs.webkit.org/show_bug.cgi?id=195318

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-03-05
Reviewed by Devin Rousso.

The bottom few pixels of the overview are reserved for the scroll-container
which may show a scrollbar if the overview needs to scroll. When the scrollbars
are not visible we can allow pointer events to click through the invisible
scroll-container and allow record selection.

  • UserInterface/Views/TimelineOverview.css:

(.timeline-overview:not(.has-scrollbar) > .scroll-container):

  • UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview.prototype._handleScrollEvent):
(WI.TimelineOverview.prototype._handleWheelEvent):
(WI.TimelineOverview._handleGestureStart):

Location:
trunk/Source/WebInspectorUI
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r242495 r242510  
     12019-03-05  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: Attempting to select records in the bottom 16px of the timeline overview graph fails
     4        https://bugs.webkit.org/show_bug.cgi?id=195318
     5
     6        Reviewed by Devin Rousso.
     7
     8        The bottom few pixels of the overview are reserved for the scroll-container
     9        which may show a scrollbar if the overview needs to scroll. When the scrollbars
     10        are not visible we can allow pointer events to click through the invisible
     11        scroll-container and allow record selection.
     12
     13        * UserInterface/Views/TimelineOverview.css:
     14        (.timeline-overview:not(.has-scrollbar) > .scroll-container):
     15        * UserInterface/Views/TimelineOverview.js:
     16        (WI.TimelineOverview.prototype._handleScrollEvent):
     17        (WI.TimelineOverview.prototype._handleWheelEvent):
     18        (WI.TimelineOverview._handleGestureStart):
     19
    1202019-03-05  Devin Rousso  <drousso@apple.com>
    221
  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css

    r240518 r242510  
    216216}
    217217
     218.timeline-overview:not(.has-scrollbar) > .scroll-container {
     219    pointer-events: none;
     220}
     221
    218222.timeline-overview > .scroll-container > .scroll-width-sizer {
    219223    position: absolute;
  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js

    r242194 r242510  
    538538
    539539        this._dontUpdateScrollLeft = false;
     540
     541        this.element.classList.toggle("has-scrollbar", this._scrollContainerElement.clientHeight <= 1);
    540542    }
    541543
     
    583585        this.scrollStartTime = mousePositionTime - (mouseOffset * this.secondsPerPixel);
    584586
     587        this.element.classList.toggle("has-scrollbar", this._scrollContainerElement.clientHeight <= 1);
     588
    585589        event.preventDefault();
    586590        event.stopPropagation();
     
    600604        this._gestureStartStartTime = mousePositionTime;
    601605        this._gestureStartDurationPerPixel = this.secondsPerPixel;
     606
     607        this.element.classList.toggle("has-scrollbar", this._scrollContainerElement.clientHeight <= 1);
    602608
    603609        event.preventDefault();
Note: See TracChangeset for help on using the changeset viewer.