Changeset 242520 in webkit


Ignore:
Timestamp:
Mar 5, 2019 4:40:44 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: recordsInTimeRange sometimes does not get the expected record when includeRecordBeforeStart
https://bugs.webkit.org/show_bug.cgi?id=195317

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-03-05
Reviewed by Devin Rousso.

  • UserInterface/Models/Timeline.js:

(WI.Timeline.prototype.recordsOverlappingTimeRange):

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r242511 r242520  
     12019-03-05  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: recordsInTimeRange sometimes does not get the expected record when includeRecordBeforeStart
     4        https://bugs.webkit.org/show_bug.cgi?id=195317
     5
     6        Reviewed by Devin Rousso.
     7
     8        * UserInterface/Models/Timeline.js:
     9        (WI.Timeline.prototype.recordsOverlappingTimeRange):
     10
    1112019-03-05  Devin Rousso  <drousso@apple.com>
    212
  • trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js

    r242104 r242520  
    108108
    109109        // Include the record right before the start time.
    110         if (includeRecordBeforeStart && lowerIndex > 0)
     110        if (includeRecordBeforeStart && lowerIndex > 0) {
    111111            lowerIndex--;
     112
     113            // If the record right before is a child of the same type of record, then use the parent as the before index.
     114            let recordBefore = this._records[lowerIndex];
     115            if (recordBefore.parent && recordBefore.parent.type === recordBefore.type) {
     116                lowerIndex--;
     117                while (this._records[lowerIndex] !== recordBefore.parent)
     118                    lowerIndex--;
     119            }
     120        }
    112121
    113122        return this._records.slice(lowerIndex, upperIndex);
Note: See TracChangeset for help on using the changeset viewer.