Changeset 242652 in webkit

Timestamp:

Mar 8, 2019 11:54:02 AM (5 years ago)

Author:

Chris Dumez

Message:

Add assertions to help debug a WebProcessCache crash
​https://bugs.webkit.org/show_bug.cgi?id=195469

Reviewed by Brady Eidson.

I suspect the process's registrableDomain in null when evictProcess() gets
called, thus crashing when lookup it up in the HashMap. Confirm this and
how this could happen via assertions.

• UIProcess/WebProcessCache.cpp:

(WebKit::WebProcessCache::evictProcess):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didStartProvisionalLoadForMainFrame):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebProcessCache.cpp (modified) (1 diff)
• UIProcess/WebProcessProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-08  Chris Dumez  <cdumez@apple.com>
+
+        Add assertions to help debug a WebProcessCache crash
+        https://bugs.webkit.org/show_bug.cgi?id=195469
+
+        Reviewed by Brady Eidson.
+
+        I suspect the process's registrableDomain in null when evictProcess() gets
+        called, thus crashing when lookup it up in the HashMap. Confirm this and
+        how this could happen via assertions.
+
+        * UIProcess/WebProcessCache.cpp:
+        (WebKit::WebProcessCache::evictProcess):
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::didStartProvisionalLoadForMainFrame):
+
 2019-03-08  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebKit/UIProcess/WebProcessCache.cpp

@@ -187 +187 @@
 void WebProcessCache::evictProcess(WebProcessProxy& process)
 {
+    RELEASE_ASSERT(!process.registrableDomain().isEmpty());
     auto it = m_processesPerRegistrableDomain.find(process.registrableDomain());
     ASSERT(it != m_processesPerRegistrableDomain.end());

trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp

@@ -1428 +1428 @@
 void WebProcessProxy::didStartProvisionalLoadForMainFrame(const URL& url)
 {
+    RELEASE_ASSERT(!isInProcessCache());
+
     // This process has been used for several registrable domains already.
     if (m_registrableDomain && m_registrableDomain->isNull())