Changeset 242706 in webkit


Ignore:
Timestamp:
Mar 11, 2019 9:25:41 AM (5 years ago)
Author:
Truitt Savell
Message:

Unreviewed, rolling out r242702.

Broke High Sierra builders.

Reverted changeset:

"Add utility function to allow easy reverse range-based
iteration of a container"
https://bugs.webkit.org/show_bug.cgi?id=195542
https://trac.webkit.org/changeset/242702

Location:
trunk
Files:
1 deleted
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WTF/ChangeLog

    r242702 r242706  
     12019-03-11  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r242702.
     4
     5        Broke High Sierra builders.
     6
     7        Reverted changeset:
     8
     9        "Add utility function to allow easy reverse range-based
     10        iteration of a container"
     11        https://bugs.webkit.org/show_bug.cgi?id=195542
     12        https://trac.webkit.org/changeset/242702
     13
    1142019-03-11  Sam Weinig  <sam@webkit.org>
    215
  • trunk/Source/WTF/wtf/IteratorRange.h

    r242702 r242706  
    2626#pragma once
    2727
    28 #include <iterator>
    29 
    3028namespace WTF {
    3129
     
    5149{
    5250    return IteratorRange<Iterator>(std::forward<Iterator>(begin), std::forward<Iterator>(end));
    53 }
    54 
    55 template<typename Container>
    56 IteratorRange<typename Container::reverse_iterator> makeReversedRange(Container& container)
    57 {
    58     return makeIteratorRange(std::rbegin(container), std::rend(container));
    59 }
    60 
    61 template<typename Container>
    62 IteratorRange<typename Container::const_reverse_iterator> makeReversedRange(const Container& container)
    63 {
    64     return makeIteratorRange(std::crbegin(container), std::crend(container));
    6551}
    6652
  • trunk/Tools/ChangeLog

    r242702 r242706  
     12019-03-11  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r242702.
     4
     5        Broke High Sierra builders.
     6
     7        Reverted changeset:
     8
     9        "Add utility function to allow easy reverse range-based
     10        iteration of a container"
     11        https://bugs.webkit.org/show_bug.cgi?id=195542
     12        https://trac.webkit.org/changeset/242702
     13
    1142019-03-11  Sam Weinig  <sam@webkit.org>
    215
  • trunk/Tools/TestWebKitAPI/CMakeLists.txt

    r242702 r242706  
    130130    ${TESTWEBKITAPI_DIR}/Tests/WTF/Hasher.cpp
    131131    ${TESTWEBKITAPI_DIR}/Tests/WTF/IntegerToStringConversion.cpp
    132     ${TESTWEBKITAPI_DIR}/Tests/WTF/IteratorRange.cpp
    133132    ${TESTWEBKITAPI_DIR}/Tests/WTF/JSONValue.cpp
    134133    ${TESTWEBKITAPI_DIR}/Tests/WTF/LEBDecoder.cpp
  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r242702 r242706  
    607607                7CCE7F2F1A411B1000447C4C /* WKBrowsingContextLoadDelegateTest.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC3C4C7014575B6A0025FB62 /* WKBrowsingContextLoadDelegateTest.mm */; };
    608608                7CD4C26E1E2C0E6E00929470 /* StringConcatenate.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7CD4C26C1E2C0E6E00929470 /* StringConcatenate.cpp */; };
    609                 7CEB62AB223609DE0069CBB0 /* IteratorRange.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7CEB62A92236086C0069CBB0 /* IteratorRange.cpp */; };
    610609                7CEFA9661AC0B9E200B910FD /* _WKUserContentExtensionStore.mm in Sources */ = {isa = PBXBuildFile; fileRef = 7CEFA9641AC0B9E200B910FD /* _WKUserContentExtensionStore.mm */; };
    611610                7CFBCAE51743238F00B2BFCF /* WillLoad_Bundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7CFBCAE31743238E00B2BFCF /* WillLoad_Bundle.cpp */; };
     
    18201819                7CD0D5AA1D5534DE000CC9E1 /* Variant.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Variant.cpp; sourceTree = "<group>"; };
    18211820                7CD4C26C1E2C0E6E00929470 /* StringConcatenate.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StringConcatenate.cpp; sourceTree = "<group>"; };
    1822                 7CEB62A92236086C0069CBB0 /* IteratorRange.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = IteratorRange.cpp; sourceTree = "<group>"; };
    18231821                7CEFA9641AC0B9E200B910FD /* _WKUserContentExtensionStore.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = _WKUserContentExtensionStore.mm; sourceTree = "<group>"; };
    18241822                7CFBCADD1743234F00B2BFCF /* WillLoad.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WillLoad.cpp; sourceTree = "<group>"; };
     
    32463244                                26B2DFF815BDE599004F691D /* HashSet.cpp */,
    32473245                                266FAFD215E5775200F61D5B /* IntegerToStringConversion.cpp */,
    3248                                 7CEB62A92236086C0069CBB0 /* IteratorRange.cpp */,
    32493246                                7A0509401FB9F04400B33FB8 /* JSONValue.cpp */,
    32503247                                531C1D8D1DF8EF72006E979F /* LEBDecoder.cpp */,
     
    38593856                                7C83DED41D0A590C00FEBCF3 /* HashSet.cpp in Sources */,
    38603857                                7C83DEE01D0A590C00FEBCF3 /* IntegerToStringConversion.cpp in Sources */,
    3861                                 7CEB62AB223609DE0069CBB0 /* IteratorRange.cpp in Sources */,
    38623858                                7A0509411FB9F06400B33FB8 /* JSONValue.cpp in Sources */,
    38633859                                531C1D8E1DF8EF72006E979F /* LEBDecoder.cpp in Sources */,
Note: See TracChangeset for help on using the changeset viewer.