Changeset 242880 in webkit

Timestamp:

Mar 13, 2019 4:27:08 AM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] status bubble should be hidden for certain builds
​https://bugs.webkit.org/show_bug.cgi?id=194597

Reviewed by Dewei Zhu.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble):
(StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
because the patch didn't have relevant changes.
(StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
in production yet.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (4 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -23 +23 @@
 from __future__ import unicode_literals
 
+import re
+
 from django.http import HttpResponse
 from django.shortcuts import render
@@ -43 +45 @@
         }
         build = self.get_latest_build_for_queue(patch, queue)
+        if not self._should_show_bubble_for_build(build):
+            return None
+
         if not build:
             bubble["state"] = "none"
@@ -80 +85 @@
         return [build for build in patch.build_set.all() if build.builder_display_name == queue]
 
-    def _should_show_bubble_for(self, patch, queue):
-        # TODO: https://bugs.webkit.org/show_bug.cgi?id=194597
+    def _should_show_bubble_for_build(self, build):
+        if build and build.result == 3 and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string):
+            return False
+        return True
+
+    def _should_show_bubble_for_queue(self, queue):
         return queue in StatusBubble.ENABLED_QUEUES
 
@@ -93 +102 @@
 
         for queue in StatusBubble.ALL_QUEUES:
-            if not self._should_show_bubble_for(patch, queue):
+            if not self._should_show_bubble_for_queue(queue):
                 continue
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-03-13  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] status bubble should be hidden for certain builds
+        https://bugs.webkit.org/show_bug.cgi?id=194597
+
+        Reviewed by Dewei Zhu.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._build_bubble):
+        (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
+        because the patch didn't have relevant changes.
+        (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
+        in production yet.
+
 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>