Changeset 242880 in webkit
- Timestamp:
- Mar 13, 2019 4:27:08 AM (5 years ago)
- Location:
- trunk/Tools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
r242827 r242880 23 23 from __future__ import unicode_literals 24 24 25 import re 26 25 27 from django.http import HttpResponse 26 28 from django.shortcuts import render … … 43 45 } 44 46 build = self.get_latest_build_for_queue(patch, queue) 47 if not self._should_show_bubble_for_build(build): 48 return None 49 45 50 if not build: 46 51 bubble["state"] = "none" … … 80 85 return [build for build in patch.build_set.all() if build.builder_display_name == queue] 81 86 82 def _should_show_bubble_for(self, patch, queue): 83 # TODO: https://bugs.webkit.org/show_bug.cgi?id=194597 87 def _should_show_bubble_for_build(self, build): 88 if build and build.result == 3 and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string): 89 return False 90 return True 91 92 def _should_show_bubble_for_queue(self, queue): 84 93 return queue in StatusBubble.ENABLED_QUEUES 85 94 … … 93 102 94 103 for queue in StatusBubble.ALL_QUEUES: 95 if not self._should_show_bubble_for (patch,queue):104 if not self._should_show_bubble_for_queue(queue): 96 105 continue 97 106 -
trunk/Tools/ChangeLog
r242842 r242880 1 2019-03-13 Aakash Jain <aakash_jain@apple.com> 2 3 [ews-app] status bubble should be hidden for certain builds 4 https://bugs.webkit.org/show_bug.cgi?id=194597 5 6 Reviewed by Dewei Zhu. 7 8 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: 9 (StatusBubble._build_bubble): 10 (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped 11 because the patch didn't have relevant changes. 12 (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed 13 in production yet. 14 1 15 2019-03-12 Ross Kirsling <ross.kirsling@sony.com> 2 16
Note: See TracChangeset
for help on using the changeset viewer.