Changeset 242916 in webkit

Timestamp:

Mar 13, 2019 4:07:06 PM (5 years ago)

Author:

yoshiaki.jitsukawa@sony.com

Message:

[bmalloc] Use MADV_FREE on FreeBSD
​https://bugs.webkit.org/show_bug.cgi?id=195665

Reviewed by Geoffrey Garen.

• bmalloc/BPlatform.h:

Introduce BOS_FREEBSD, which is equivalent to WTF_OS_FREEBSD

• bmalloc/VMAllocate.h:

(bmalloc::vmDeallocatePhysicalPages):

Use MADV_FREE instead of MADV_DONTNEED if BOS(FREEBSD), since on FreeBSD,
unlike on Linux, MADV_DONTNEED doesn't let the OS discard the contents of
the pages.

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• bmalloc/BPlatform.h (modified) (1 diff)
• bmalloc/VMAllocate.h (modified) (1 diff)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2019-03-13  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
+
+        [bmalloc] Use MADV_FREE on FreeBSD
+        https://bugs.webkit.org/show_bug.cgi?id=195665
+
+        Reviewed by Geoffrey Garen.
+
+        * bmalloc/BPlatform.h:
+
+        Introduce BOS_FREEBSD, which is equivalent to WTF_OS_FREEBSD
+
+        * bmalloc/VMAllocate.h:
+        (bmalloc::vmDeallocatePhysicalPages):
+
+        Use MADV_FREE instead of MADV_DONTNEED if BOS(FREEBSD), since on FreeBSD,
+        unlike on Linux, MADV_DONTNEED doesn't let the OS discard the contents of
+        the pages.
+
 2019-03-13  Sam Weinig  <sam@webkit.org>
 

trunk/Source/bmalloc/bmalloc/BPlatform.h

@@ -49 +49 @@
 #endif
 
+#if defined(__FreeBSD__) || defined(__DragonFly__) || defined(__FreeBSD_kernel__)
+#define BOS_FREEBSD 1
+#endif
+
 #if defined(WIN32) || defined(_WIN32)
 #define BOS_WINDOWS 1

trunk/Source/bmalloc/bmalloc/VMAllocate.h

@@ -202 +202 @@
 #if BOS(DARWIN)
     SYSCALL(madvise(p, vmSize, MADV_FREE_REUSABLE));
+#elif BOS(FREEBSD)
+    SYSCALL(madvise(p, vmSize, MADV_FREE));
 #else
     SYSCALL(madvise(p, vmSize, MADV_DONTNEED));