Changeset 242965 in webkit

Timestamp:

Mar 14, 2019 2:33:47 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Status bubble display pending for currently running build step
​https://bugs.webkit.org/show_bug.cgi?id=195744

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-build/events.py:

(Events.stepStarted): If state_string is pending, replace it with step name.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/events.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/events.py

@@ -162 +162 @@
 
     def stepStarted(self, key, step):
+        state_string = step.get('state_string')
+        if state_string == 'pending':
+            state_string = 'Running {}'.format(step.get('name'))
+
         data = {
             "type": self.type_prefix + "step",
             "status": "started",
+            "hostname": self.master_hostname,
+            "step_id": step.get('stepid'),
+            "build_id": step.get('buildid'),
+            "result": step.get('results'),
+            "state_string": state_string,
+            "started_at": step.get('started_at'),
+            "complete_at": step.get('complete_at'),
+        }
+
+        self.sendData(data)
+
+    def stepFinished(self, key, step):
+        data = {
+            "type": self.type_prefix + "step",
+            "status": "finished",
             "hostname": self.master_hostname,
             "step_id": step.get('stepid'),
@@ -176 +195 @@
         self.sendData(data)
 
-    def stepFinished(self, key, step):
-        data = {
-            "type": self.type_prefix + "step",
-            "status": "finished",
-            "hostname": self.master_hostname,
-            "step_id": step.get('stepid'),
-            "build_id": step.get('buildid'),
-            "result": step.get('results'),
-            "state_string": step.get('state_string'),
-            "started_at": step.get('started_at'),
-            "complete_at": step.get('complete_at'),
-        }
-
-        self.sendData(data)
-
     @defer.inlineCallbacks
     def startService(self):

trunk/Tools/ChangeLog

@@ +1 @@
+2019-03-14  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Status bubble display pending for currently running build step
+        https://bugs.webkit.org/show_bug.cgi?id=195744
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/events.py:
+        (Events.stepStarted): If state_string is pending, replace it with step name.
+
 2019-03-14  Chris Dumez  <cdumez@apple.com>