Changeset 243105 in webkit

Timestamp:

Mar 18, 2019 2:30:58 PM (5 years ago)

Author:

mmaxfield@apple.com

Message:

[WHLSL] Hook up the compiler to our WebGPU implementation
​https://bugs.webkit.org/show_bug.cgi?id=195509

Unreviewed.

Update after r243091.

Source/WebCore:

• Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:
• platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:

(WebCore::trySetWHLSLFunctionsForPipelineDescriptor):

LayoutTests:

• webgpu/whlsl.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webgpu/whlsl.html (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp (modified) (1 diff)
• Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-03-18  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [WHLSL] Hook up the compiler to our WebGPU implementation
+        https://bugs.webkit.org/show_bug.cgi?id=195509
+
+        Unreviewed.
+
+        Update after r243091.
+
+        * webgpu/whlsl.html:
+
 2019-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/LayoutTests/webgpu/whlsl.html

@@ -17 +17 @@
 async function start() {
     const adapter = await window.gpu.requestAdapter();
-    const device = adapter.createDevice();
+    const device = await adapter.requestDevice();
 
     const shaderModule = device.createShaderModule({code: shaderSource, isWHLSL: true});
@@ -94 +94 @@
     const swapChain = device.createSwapChain(swapChainDescriptor);
     const outputTexture = swapChain.getCurrentTexture();
-    const outputTextureView = outputTexture.createDefaultTextureView(); // createDefaultView()
+    const outputTextureView = outputTexture.createDefaultView(); // createDefaultView()
 
     const commandEncoder = device.createCommandEncoder(); // {}

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-18  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [WHLSL] Hook up the compiler to our WebGPU implementation
+        https://bugs.webkit.org/show_bug.cgi?id=195509
+
+        Unreviewed.
+
+        Update after r243091.
+
+        * Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:
+        * platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
+        (WebCore::trySetWHLSLFunctionsForPipelineDescriptor):
+
 2019-03-18  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp

@@ -32 +32 @@
 #include "WHLSLArrayReferenceType.h"
 #include "WHLSLEnumerationDefinition.h"
+#include "WHLSLInferTypes.h"
 #include "WHLSLNativeFunctionDeclaration.h"
 #include "WHLSLNativeTypeDeclaration.h"

trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm

@@ -260 +260 @@
         return false;
 
-    WTFLogAlways("Metal code: %s", result->metalSource.utf8().data());
-
     NSError *error = nil;
     auto library = adoptNS([device.platformDevice() newLibraryWithSource:result->metalSource options:nil error:&error]);