Changeset 243295 in webkit

Timestamp:

Mar 21, 2019 9:45:25 AM (5 years ago)

Author:

Tadeu Zagallo

Message:

CachedUnlinkedSourceCodeShape::m_provider should be a CachedRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=196079

Reviewed by Saam Barati.

It was mistakenly cached as CachedPtr, which was leaking the decoded SourceProvider.

• runtime/CachedTypes.cpp:

(JSC::CachedUnlinkedSourceCodeShape::encode):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/CachedTypes.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-03-21  Tadeu Zagallo  <tzagallo@apple.com>
+
+        CachedUnlinkedSourceCodeShape::m_provider should be a CachedRefPtr
+        https://bugs.webkit.org/show_bug.cgi?id=196079
+
+        Reviewed by Saam Barati.
+
+        It was mistakenly cached as CachedPtr, which was leaking the decoded SourceProvider.
+
+        * runtime/CachedTypes.cpp:
+        (JSC::CachedUnlinkedSourceCodeShape::encode):
+
 2019-03-21  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/runtime/CachedTypes.cpp

@@ -1476 +1476 @@
     void encode(Encoder& encoder, const UnlinkedSourceCode& sourceCode)
     {
-        m_provider.encode(encoder, sourceCode.m_provider.get());
+        m_provider.encode(encoder, sourceCode.m_provider);
         m_startOffset = sourceCode.startOffset();
         m_endOffset = sourceCode.endOffset();
@@ -1489 +1489 @@
 
 private:
-    CachedPtr<CachedSourceProvider> m_provider;
+    CachedRefPtr<CachedSourceProvider> m_provider;
     int m_startOffset;
     int m_endOffset;