Changeset 243424 in webkit

Timestamp:

Mar 24, 2019 1:21:13 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Canvas: missing icons for WebGL2 contexts
​https://bugs.webkit.org/show_bug.cgi?id=196136

Reviewed by Timothy Hatcher.

• UserInterface/Views/CanvasSidebarPanel.css:

(.sidebar > .panel.navigation.canvas > .navigation-bar > .item.record-start-stop.disabled > .glyph): Added.
(.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.canvas:matches(.canvas-2d, .bitmaprenderer) .icon): Added.
(.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.canvas:matches(.webgl, .webgl2, .webgpu, .webmetal) .icon): Added.
(@media (prefers-color-scheme: dark)):
(.sidebar > .panel.navigation.canvas > .navigation-bar > .item.record-start-stop.disabled): Deleted.
(.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.canvas.canvas-2d .icon): Deleted.
(.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.casnvas.webgl .icon): Deleted.
Use the 2D icon for BitmapRenderer and the 3D icon for WebGL2, WebMetals, and WebGPU.
Drive-by: the start/stop button text was too dark when disabled in dark mode.

• UserInterface/Models/Canvas.js:

Drive-by: "gpu" => "webgpu", to match the protocol string.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/Canvas.js (modified) (1 diff)
• UserInterface/Views/CanvasSidebarPanel.css (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-03-24  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Canvas: missing icons for WebGL2 contexts
+        https://bugs.webkit.org/show_bug.cgi?id=196136
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/CanvasSidebarPanel.css:
+        (.sidebar > .panel.navigation.canvas > .navigation-bar > .item.record-start-stop.disabled > .glyph): Added.
+        (.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.canvas:matches(.canvas-2d, .bitmaprenderer) .icon): Added.
+        (.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.canvas:matches(.webgl, .webgl2, .webgpu, .webmetal) .icon): Added.
+        (@media (prefers-color-scheme: dark)):
+        (.sidebar > .panel.navigation.canvas > .navigation-bar > .item.record-start-stop.disabled): Deleted.
+        (.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.canvas.canvas-2d .icon): Deleted.
+        (.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.casnvas.webgl .icon): Deleted.
+        Use the 2D icon for BitmapRenderer and the 3D icon for WebGL2, WebMetals, and WebGPU.
+        Drive-by: the start/stop button text was too dark when disabled in dark mode.
+
+        * UserInterface/Models/Canvas.js:
+        Drive-by: "gpu" => "webgpu", to match the protocol string.
+
 2019-03-22  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/Canvas.js

@@ -413 +413 @@
     WebGL: "webgl",
     WebGL2: "webgl2",
-    WebGPU: "gpu",
+    WebGPU: "webgpu",
     WebMetal: "webmetal",
 };

trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css

@@ -31 +31 @@
 }
 
-.sidebar > .panel.navigation.canvas > .navigation-bar > .item.record-start-stop.disabled {
+.sidebar > .panel.navigation.canvas > .navigation-bar > .item.record-start-stop.disabled > .glyph {
     filter: grayscale();
     opacity: 0.5;
 }
 
-.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.canvas.canvas-2d .icon {
+.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.canvas:matches(.canvas-2d, .bitmaprenderer) .icon {
     content: url(../Images/Canvas2D.svg);
 }
 
-.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.canvas.webgl .icon {
+.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.canvas:matches(.webgl, .webgl2, .webgpu, .webmetal) .icon {
     content: url(../Images/Canvas3D.svg);
 }
@@ -101 +101 @@
 
 @media (prefers-color-scheme: dark) {
-    .sidebar > .panel.navigation.canvas > .navigation-bar > .item.record-start-stop.disabled {
+    .sidebar > .panel.navigation.canvas > .navigation-bar > .item.record-start-stop.disabled > .glyph {
         filter: grayscale() invert();
     }