Changeset 243444 in webkit

Timestamp:

Mar 25, 2019 11:27:55 AM (5 years ago)

Author:

Antti Koivisto

Message:

Toggling "display: contents" to "display: none" fails to hide the element
​https://bugs.webkit.org/show_bug.cgi?id=188259
<rdar://problem/42886896>

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/display-contents-to-none.html

• style/StyleTreeResolver.cpp:

(WebCore::Style::affectsRenderedSubtree):

An element with 'display:contents' has a rendered subtree.

LayoutTests:

• fast/css/display-contents-to-none-expected.html: Added.
• fast/css/display-contents-to-none.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/display-contents-to-none-expected.html (added)
• LayoutTests/fast/css/display-contents-to-none.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/style/StyleTreeResolver.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-03-25  Antti Koivisto  <antti@apple.com>
+
+        Toggling "display: contents" to "display: none" fails to hide the element
+        https://bugs.webkit.org/show_bug.cgi?id=188259
+        <rdar://problem/42886896>
+
+        Reviewed by Simon Fraser.
+
+        * fast/css/display-contents-to-none-expected.html: Added.
+        * fast/css/display-contents-to-none.html: Added.
+
 2019-03-25  Diego Pino Garcia  <dpino@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-25  Antti Koivisto  <antti@apple.com>
+
+        Toggling "display: contents" to "display: none" fails to hide the element
+        https://bugs.webkit.org/show_bug.cgi?id=188259
+        <rdar://problem/42886896>
+
+        Reviewed by Simon Fraser.
+
+        Test: fast/css/display-contents-to-none.html
+
+        * style/StyleTreeResolver.cpp:
+        (WebCore::Style::affectsRenderedSubtree):
+
+        An element with 'display:contents' has a rendered subtree.
+
 2019-03-25  Justin Fan  <justin_fan@apple.com>
 

trunk/Source/WebCore/style/StyleTreeResolver.cpp

@@ -159 +159 @@
 static bool affectsRenderedSubtree(Element& element, const RenderStyle& newStyle)
 {
-    if (element.renderer())
-        return true;
     if (newStyle.display() != DisplayType::None)
+        return true;
+    if (element.renderOrDisplayContentsStyle())
         return true;
     if (element.rendererIsNeeded(newStyle))