Changeset 243452 in webkit

Timestamp:

Mar 25, 2019 1:45:37 PM (5 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Page Weight indicator clears on pages with zero length resources (macrumors.com)
​https://bugs.webkit.org/show_bug.cgi?id=196170

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

• UserInterface/Models/DefaultDashboard.js:

(WI.DefaultDashboard.prototype._resourceSizeDidChange):
Catch NaN earlier.

• UserInterface/Models/Resource.js:

(WI.Resource.prototype.updateWithMetrics):
When we receive exact metrics transition the estimated size to zero,
since we won't receive any more updates for the resource.

LayoutTests:

• http/tests/inspector/network/resource-sizes-network.html:
• http/tests/inspector/network/resources/empty.txt: Added.
• platform/mac/http/tests/inspector/network/resource-sizes-network-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/inspector/network/resource-sizes-network.html (modified) (1 diff)
• LayoutTests/http/tests/inspector/network/resources/empty.txt (added)
• LayoutTests/platform/mac/http/tests/inspector/network/resource-sizes-network-expected.txt (modified) (1 diff)
• Source/WebInspectorUI/ChangeLog (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Models/Resource.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-03-25  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Page Weight indicator clears on pages with zero length resources (macrumors.com)
+        https://bugs.webkit.org/show_bug.cgi?id=196170
+
+        Reviewed by Timothy Hatcher.
+
+        * http/tests/inspector/network/resource-sizes-network.html:
+        * http/tests/inspector/network/resources/empty.txt: Added.
+        * platform/mac/http/tests/inspector/network/resource-sizes-network-expected.txt:
+
 2019-03-25  Eric Carlson  <eric.carlson@apple.com>
 

trunk/LayoutTests/http/tests/inspector/network/resource-sizes-network.html

@@ -41 +41 @@
         responseBodyTransferSize: 2955,
         size: 2955,
+    });
+
+    addResourceSizeTest(suite, {
+        name: "Resource.Size.Network.text",
+        description: "Sizes of an empty text resource",
+        url: "resources/empty.txt?" + Math.random(),
+        statusCode: 200,
+        compressed: false,
+        responseSource: WI.Resource.ResponseSource.Network,
+        headers: true,
+        requestBodyTransferSize: 0,
+        responseBodyTransferSize: 0,
+        size: 0,
     });
 

trunk/LayoutTests/platform/mac/http/tests/inspector/network/resource-sizes-network-expected.txt

@@ -14 +14 @@
 PASS: requestBodyTransferSize should be exactly 0 bytes.
 PASS: responseBodyTransferSize should be exactly 2955 bytes.
+PASS: requestHeadersTransferSize should be non-empty.
+PASS: responseHeadersTransferSize should be non-empty.
+
+-- Running test case: Resource.Size.Network.text
+PASS: statusCode should be 200.
+PASS: compressed should be false.
+PASS: responseSource should be Symbol(network).
+PASS: estimatedNetworkEncodedSize should be exactly 0 bytes.
+PASS: estimatedTotalTransferSize should be >= (encoded body size + headers).
+PASS: size should be exactly 0 bytes.
+PASS: networkEncodedSize should be exactly 0 bytes.
+PASS: networkTotalTransferSize should be >= (encoded body size + headers).
+PASS: requestBodyTransferSize should be exactly 0 bytes.
+PASS: responseBodyTransferSize should be exactly 0 bytes.
 PASS: requestHeadersTransferSize should be non-empty.
 PASS: responseHeadersTransferSize should be non-empty.

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-03-25  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Page Weight indicator clears on pages with zero length resources (macrumors.com)
+        https://bugs.webkit.org/show_bug.cgi?id=196170
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Models/DefaultDashboard.js:
+        (WI.DefaultDashboard.prototype._resourceSizeDidChange):
+        Catch NaN earlier.
+
+        * UserInterface/Models/Resource.js:
+        (WI.Resource.prototype.updateWithMetrics):
+        When we receive exact metrics transition the estimated size to zero,
+        since we won't receive any more updates for the resource.
+
 2019-03-24  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js

@@ -184 +184 @@
         if (event.target.urlComponents.scheme === "data")
             return;
-        this.resourcesSize += event.target.size - event.data.previousSize;
+
+        let delta = event.target.size - event.data.previousSize;
+        console.assert(!isNaN(delta), "Resource size change should never be NaN.");
+        this.resourcesSize += delta;
     }
 

trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js

@@ -790 +790 @@
             console.assert(this._responseBodySize >= 0);
 
+            // There may have been no size updates received during load if Content-Length was 0.
+            if (isNaN(this._estimatedSize))
+                this._estimatedSize = 0;
+
             this.dispatchEventToListeners(WI.Resource.Event.SizeDidChange, {previousSize: this._estimatedSize});
             this.dispatchEventToListeners(WI.Resource.Event.TransferSizeDidChange);