Changeset 243468 in webkit

Timestamp:

Mar 25, 2019 4:11:09 PM (5 years ago)

Author:

Simon Fraser

Message:

Zoom on macOS is centered around a point lower than the cursor
​https://bugs.webkit.org/show_bug.cgi?id=196225
rdar://problem/49213574

Reviewed by Tim Horton.

The origin handed to ViewGestureController::handleMagnificationGestureEvent is in WKWebView
coordinates, but we end up setting the transform on the RenderView's layer, so we need
to subtract the topContentInset.

• UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::handleMagnificationGestureEvent):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/mac/ViewGestureControllerMac.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-25  Simon Fraser  <simon.fraser@apple.com>
+
+        Zoom on macOS is centered around a point lower than the cursor
+        https://bugs.webkit.org/show_bug.cgi?id=196225
+        rdar://problem/49213574
+
+        Reviewed by Tim Horton.
+        
+        The origin handed to ViewGestureController::handleMagnificationGestureEvent is in WKWebView
+        coordinates, but we end up setting the transform on the RenderView's layer, so we need
+        to subtract the topContentInset.
+
+        * UIProcess/mac/ViewGestureControllerMac.mm:
+        (WebKit::ViewGestureController::handleMagnificationGestureEvent):
+
 2019-03-25  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm

@@ -135 +135 @@
 void ViewGestureController::handleMagnificationGestureEvent(NSEvent *event, FloatPoint origin)
 {
+    origin.setY(origin.y() - m_webPageProxy.topContentInset());
+
     ASSERT(m_activeGestureType == ViewGestureType::None || m_activeGestureType == ViewGestureType::Magnification);