Changeset 243469 in webkit

Timestamp:

Mar 25, 2019, 4:11:11 PM (6 years ago)

Author:

Simon Fraser

Message:

REGRESSION (r242687): Flicker when pinch-zooming pages in macOS Safari
​https://bugs.webkit.org/show_bug.cgi?id=196126
rdar://problem/49095791

Reviewed by Tim Horton.

I fumbled the commit after the enum rename. Make this actually work.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-25  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r242687): Flicker when pinch-zooming pages in macOS Safari
+        https://bugs.webkit.org/show_bug.cgi?id=196126
+        rdar://problem/49095791
+
+        Reviewed by Tim Horton.
+        
+        I fumbled the commit after the enum rename. Make this actually work.
+
+        * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+        (WebKit::TiledCoreAnimationDrawingArea::flushLayers):
+
 2019-03-25  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm

@@ -494 +494 @@
         if (auto* scrollingCoordinator = m_webPage.corePage()->scrollingCoordinator()) {
             scrollingCoordinator->commitTreeStateIfNeeded();
-            if (flushType == FlushType::TransientZoom)
+            if (flushType == FlushType::Normal)
                 scrollingCoordinator->applyScrollingTreeLayerPositions();
         }