Changeset 243603 in webkit

Timestamp:

Mar 28, 2019 7:18:38 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Silence lot of warnings when compiling with clang
​https://bugs.webkit.org/show_bug.cgi?id=196310

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2019-03-28
Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

Initialize variable with default constructor.

• API/glib/JSCOptions.cpp:

(jsc_options_foreach):

Source/WebCore:

No change in behavior.

• accessibility/AccessibilityObject.h: add missing override

clause.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcChangeState): add missing format string to log.

• platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h: add

missing virtual destructor.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

add missing override clause and remove unused private member.

Source/WebKit:

• UIProcess/API/glib/WebKitInjectedBundleClient.cpp: add missing

override clause.

• WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h: add

missing override clause.

Location:

trunk/Source

Files:

• JavaScriptCore/API/glib/JSCOptions.cpp (modified) (1 diff)
• JavaScriptCore/ChangeLog (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/accessibility/AccessibilityObject.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h (modified) (1 diff)
• WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h (modified) (2 diffs)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/API/glib/WebKitInjectedBundleClient.cpp (modified) (1 diff)
• WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/API/glib/JSCOptions.cpp

@@ -618 +618 @@
     if (Options::Availability::availability_ == Options::Availability::Normal \
         || Options::isAvailable(Options::name_##ID, Options::Availability::availability_)) { \
-        type_ defaultValue;                                             \
+        type_ defaultValue { };                                         \
         auto optionType = jscOptionsType(defaultValue);                 \
         if (function (#name_, optionType, description_, userData))      \

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-03-28  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
+
+        Silence lot of warnings when compiling with clang
+        https://bugs.webkit.org/show_bug.cgi?id=196310
+
+        Reviewed by Michael Catanzaro.
+
+        Initialize variable with default constructor.
+
+        * API/glib/JSCOptions.cpp:
+        (jsc_options_foreach):
+
 2019-03-27  Saam Barati  <sbarati@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-28  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
+
+        Silence lot of warnings when compiling with clang
+        https://bugs.webkit.org/show_bug.cgi?id=196310
+
+        Reviewed by Michael Catanzaro.
+
+        No change in behavior.
+
+        * accessibility/AccessibilityObject.h: add missing override
+        clause.
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (webKitWebSrcChangeState): add missing format string to log.
+        * platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h: add
+        missing virtual destructor.
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
+        add missing override clause and remove unused private member.
+
 2019-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/accessibility/AccessibilityObject.h

@@ -938 +938 @@
 #if HAVE(ACCESSIBILITY)
 #if PLATFORM(GTK)
-    AccessibilityObjectWrapper* wrapper() const;
+    AccessibilityObjectWrapper* wrapper() const override;
     void setWrapper(AccessibilityObjectWrapper*);
 #else

trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

@@ -739 +739 @@
 
 #if GST_CHECK_VERSION(1, 14, 0)
-    GST_DEBUG_OBJECT(src, gst_state_change_get_name(transition));
+    GST_DEBUG_OBJECT(src, "%s", gst_state_change_get_name(transition));
 #endif
     switch (transition) {

trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h

@@ -69 +69 @@
     public:
         virtual void setVideoRectangle(const IntRect&) = 0;
+        virtual ~HolePunchClient() = 0;
     };
 

trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h

@@ -125 +125 @@
 
 private:
-    bool isCoordinatedGraphicsLayer() const;
+    bool isCoordinatedGraphicsLayer() const override;
 
     void updatePlatformLayer();
@@ -167 +167 @@
 #endif
     bool m_shouldUpdateVisibleRect: 1;
-    bool m_shouldSyncLayerState: 1;
     bool m_movingVisibleRect : 1;
     bool m_pendingContentsScaleAdjustment : 1;

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-28  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
+
+        Silence lot of warnings when compiling with clang
+        https://bugs.webkit.org/show_bug.cgi?id=196310
+
+        Reviewed by Michael Catanzaro.
+
+        * UIProcess/API/glib/WebKitInjectedBundleClient.cpp: add missing
+        override clause.
+        * WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h: add
+        missing override clause.
+
 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebKit/UIProcess/API/glib/WebKitInjectedBundleClient.cpp

@@ -132 +132 @@
     }
 
-    RefPtr<API::Object> getInjectedBundleInitializationUserData(WebProcessPool&)
+    RefPtr<API::Object> getInjectedBundleInitializationUserData(WebProcessPool&) override
     {
         GRefPtr<GVariant> data = webkitWebContextInitializeWebExtensions(m_webContext);

trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h

@@ -138 +138 @@
         }
 
-        void resize(const WebCore::IntSize& size)
+        void resize(const WebCore::IntSize& size) override
         {
             if (m_layerTreeHost.m_surface)
@@ -159 +159 @@
         }
 
-        void handleDisplayRefreshMonitorUpdate(bool hasBeenRescheduled)
+        void handleDisplayRefreshMonitorUpdate(bool hasBeenRescheduled) override
         {
             m_layerTreeHost.handleDisplayRefreshMonitorUpdate(hasBeenRescheduled);