Changeset 243697 in webkit

Timestamp:

Apr 1, 2019 10:27:53 AM (5 years ago)

Author:

Michael Catanzaro

Message:

Stop trying to support building JSC with clang 3.8
​https://bugs.webkit.org/show_bug.cgi?id=195947
<rdar://problem/49069219>

Reviewed by Darin Adler.

It seems WebKit hasn't built with clang 3.8 in a while, no devs are using this compiler, we
don't know how much effort it would be to make JSC work again, and it's making the code
Source/JavaScriptCore:

worse. Remove my hacks to support clang 3.8 from JSC.

• bindings/ScriptValue.cpp:

(Inspector::jsToInspectorValue):

• bytecode/GetterSetterAccessCase.cpp:

(JSC::GetterSetterAccessCase::create):
(JSC::GetterSetterAccessCase::clone const):

• bytecode/InstanceOfAccessCase.cpp:

(JSC::InstanceOfAccessCase::clone const):

• bytecode/IntrinsicGetterAccessCase.cpp:

(JSC::IntrinsicGetterAccessCase::clone const):

• bytecode/ModuleNamespaceAccessCase.cpp:

(JSC::ModuleNamespaceAccessCase::clone const):

• bytecode/ProxyableAccessCase.cpp:

(JSC::ProxyableAccessCase::clone const):

Source/WTF:

worse. Remove my hacks to support clang 3.8 from WTF.

• wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::allocate):

• wtf/text/StringConcatenate.h:

(WTF::tryMakeStringFromAdapters):

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/bindings/ScriptValue.cpp (modified) (2 diffs)
• JavaScriptCore/bytecode/GetterSetterAccessCase.cpp (modified) (3 diffs)
• JavaScriptCore/bytecode/InstanceOfAccessCase.cpp (modified) (1 diff)
• JavaScriptCore/bytecode/IntrinsicGetterAccessCase.cpp (modified) (1 diff)
• JavaScriptCore/bytecode/ModuleNamespaceAccessCase.cpp (modified) (1 diff)
• JavaScriptCore/bytecode/ProxyableAccessCase.cpp (modified) (1 diff)
• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/MetaAllocator.cpp (modified) (1 diff)
• WTF/wtf/text/StringConcatenate.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-04-01  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Stop trying to support building JSC with clang 3.8
+        https://bugs.webkit.org/show_bug.cgi?id=195947
+        <rdar://problem/49069219>
+
+        Reviewed by Darin Adler.
+
+        It seems WebKit hasn't built with clang 3.8 in a while, no devs are using this compiler, we
+        don't know how much effort it would be to make JSC work again, and it's making the code
+        worse. Remove my hacks to support clang 3.8 from JSC.
+
+        * bindings/ScriptValue.cpp:
+        (Inspector::jsToInspectorValue):
+        * bytecode/GetterSetterAccessCase.cpp:
+        (JSC::GetterSetterAccessCase::create):
+        (JSC::GetterSetterAccessCase::clone const):
+        * bytecode/InstanceOfAccessCase.cpp:
+        (JSC::InstanceOfAccessCase::clone const):
+        * bytecode/IntrinsicGetterAccessCase.cpp:
+        (JSC::IntrinsicGetterAccessCase::clone const):
+        * bytecode/ModuleNamespaceAccessCase.cpp:
+        (JSC::ModuleNamespaceAccessCase::clone const):
+        * bytecode/ProxyableAccessCase.cpp:
+        (JSC::ProxyableAccessCase::clone const):
+
 2019-03-31  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/bindings/ScriptValue.cpp

@@ -75 +75 @@
                 inspectorArray->pushValue(WTFMove(elementValue));
             }
-            return RefPtr<JSON::Value> { WTFMove(inspectorArray) };
+            return inspectorArray;
         }
         VM& vm = scriptState.vm();
@@ -88 +88 @@
             inspectorObject->setValue(name.string(), WTFMove(inspectorValue));
         }
-        return RefPtr<JSON::Value> { WTFMove(inspectorObject) };
+        return inspectorObject;
     }
 

trunk/Source/JavaScriptCore/bytecode/GetterSetterAccessCase.cpp

@@ -67 +67 @@
     result->m_domAttribute = domAttribute;
     result->m_customAccessor = customGetter ? FunctionPtr<OperationPtrTag>(customGetter) : nullptr;
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 
@@ -77 +77 @@
     std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(vm, owner, type, offset, structure, conditionSet, false, nullptr, customSlotBase, WTFMove(prototypeAccessChain)));
     result->m_customAccessor = customSetter ? FunctionPtr<OperationPtrTag>(customSetter) : nullptr;
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 
@@ -98 +98 @@
     std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(*this));
     result->resetState();
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 

trunk/Source/JavaScriptCore/bytecode/InstanceOfAccessCase.cpp

@@ -48 +48 @@
     std::unique_ptr<InstanceOfAccessCase> result(new InstanceOfAccessCase(*this));
     result->resetState();
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 

trunk/Source/JavaScriptCore/bytecode/IntrinsicGetterAccessCase.cpp

@@ -52 +52 @@
     std::unique_ptr<IntrinsicGetterAccessCase> result(new IntrinsicGetterAccessCase(*this));
     result->resetState();
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 

trunk/Source/JavaScriptCore/bytecode/ModuleNamespaceAccessCase.cpp

@@ -59 +59 @@
     std::unique_ptr<ModuleNamespaceAccessCase> result(new ModuleNamespaceAccessCase(*this));
     result->resetState();
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 

trunk/Source/JavaScriptCore/bytecode/ProxyableAccessCase.cpp

@@ -53 +53 @@
     std::unique_ptr<ProxyableAccessCase> result(new ProxyableAccessCase(*this));
     result->resetState();
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-04-01  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Stop trying to support building JSC with clang 3.8
+        https://bugs.webkit.org/show_bug.cgi?id=195947
+        <rdar://problem/49069219>
+
+        Reviewed by Darin Adler.
+
+        It seems WebKit hasn't built with clang 3.8 in a while, no devs are using this compiler, we
+        don't know how much effort it would be to make JSC work again, and it's making the code
+        worse. Remove my hacks to support clang 3.8 from WTF.
+
+        * wtf/MetaAllocator.cpp:
+        (WTF::MetaAllocator::allocate):
+        * wtf/text/StringConcatenate.h:
+        (WTF::tryMakeStringFromAdapters):
+
 2019-03-31  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/WTF/wtf/MetaAllocator.cpp

@@ -195 +195 @@
         m_tracker->notify(handle.ptr());
 
-    return RefPtr<MetaAllocatorHandle> { WTFMove(handle) };
+    return handle;
 }
 

trunk/Source/WTF/wtf/text/StringConcatenate.h

@@ -279 +279 @@
         makeStringAccumulator(buffer, adapter, adapters...);
 
-        return String { WTFMove(resultImpl) };
+        return resultImpl;
     }
 
@@ -289 +289 @@
     makeStringAccumulator(buffer, adapter, adapters...);
 
-    return String { WTFMove(resultImpl) };
+    return resultImpl;
 }