Changeset 243716 in webkit

Timestamp:

Apr 1, 2019 2:57:13 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Use API_KEY to accept results data
​https://bugs.webkit.org/show_bug.cgi?id=196461

Reviewed by Dewei Zhu.

• BuildSlaveSupport/ews-app/ews/views/results.py:

(Results.post): Validate EWS_API_KEY before accepting any data.

• BuildSlaveSupport/ews-build/events.py:

(Events.sendData): Send EWS_API_KEY if available along with event data.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/results.py (modified) (2 diffs)
• BuildSlaveSupport/ews-build/events.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/results.py

@@ -25 +25 @@
 import json
 import logging
+import os
 
 from django.http import HttpResponse
@@ -42 +43 @@
     def post(self, request):
         data = json.loads(request.body)
+
+        if data.get('EWS_API_KEY') != os.getenv('EWS_API_KEY', None):
+            _log.error('Incorrect API Key {}. Host: {}. Ignoring data.'.format(data.get('EWS_API_KEY'), data.get('hostname')))
+            return HttpResponse('Incorrect API Key received')
 
         if data.get('type') == u'ews-build':

trunk/Tools/BuildSlaveSupport/ews-build/events.py

@@ -23 +23 @@
 import datetime
 import json
+import os
 import time
 
@@ -89 +90 @@
 
     def sendData(self, data):
+        if os.getenv('EWS_API_KEY', None):
+            data['EWS_API_KEY'] = os.getenv('EWS_API_KEY')
         agent = Agent(reactor)
         body = JSONProducer(data)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-01  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Use API_KEY to accept results data
+        https://bugs.webkit.org/show_bug.cgi?id=196461
+
+        Reviewed by Dewei Zhu.
+
+        * BuildSlaveSupport/ews-app/ews/views/results.py:
+        (Results.post): Validate EWS_API_KEY before accepting any data.
+        * BuildSlaveSupport/ews-build/events.py:
+        (Events.sendData): Send EWS_API_KEY if available along with event data.
+
 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>