Changeset 243796 in webkit

Timestamp:

Apr 3, 2019 6:00:16 AM (5 years ago)

Author:

Carlos Garcia Campos

Message:

[CoordinatedGraphics] Hidden pages are not suspended after a web view resize
​https://bugs.webkit.org/show_bug.cgi?id=196487

Reviewed by Žan Doberšek.

When resizing the window, the hidden tabs are updated too, to avoid flickering or getting the old size when
switching tabs. For that we need to resume painting but we are not suspending it again after the update.

• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState): Suspend the painting again after a
synchronous update if needed.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [CoordinatedGraphics] Hidden pages are not suspended after a web view resize
+        https://bugs.webkit.org/show_bug.cgi?id=196487
+
+        Reviewed by Žan Doberšek.
+
+        When resizing the window, the hidden tabs are updated too, to avoid flickering or getting the old size when
+        switching tabs. For that we need to resume painting but we are not suspending it again after the update.
+
+        * WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
+        (WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState): Suspend the painting again after a
+        synchronous update if needed.
+
 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp

@@ -412 +412 @@
         // Make sure to resume painting if we're supposed to respond immediately, otherwise we'll just
         // send back an empty UpdateInfo struct.
+        bool wasSuspended = m_isPaintingSuspended;
         if (m_isPaintingSuspended)
             resumePainting();
 
         sendDidUpdateBackingStoreState();
+        if (wasSuspended)
+            suspendPainting();
     }