Changeset 243816 in webkit

Timestamp:

Apr 3, 2019 11:05:03 AM (5 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Uncaught Exception: TypeError: this._computedStyleSection.focus is not a function. (In 'this._computedStyleSection.focus()', 'this._computedStyleSection.focus' is undefined)
​https://bugs.webkit.org/show_bug.cgi?id=192108
<rdar://problem/46685392>

Reviewed by Devin Rousso.

This patch fixes the uncaught exception. Tabbing to and from "Properties" section continues
working the same way as before the patch.

• UserInterface/Views/ComputedStyleDetailsPanel.js:

(WI.ComputedStyleDetailsPanel.prototype.focusFirstSection): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.focusLastSection): Deleted.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ComputedStyleDetailsPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-04-03  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Uncaught Exception: TypeError: this._computedStyleSection.focus is not a function. (In 'this._computedStyleSection.focus()', 'this._computedStyleSection.focus' is undefined)
+        https://bugs.webkit.org/show_bug.cgi?id=192108
+        <rdar://problem/46685392>
+
+        Reviewed by Devin Rousso.
+
+        This patch fixes the uncaught exception. Tabbing to and from "Properties" section continues
+        working the same way as before the patch.
+
+        * UserInterface/Views/ComputedStyleDetailsPanel.js:
+        (WI.ComputedStyleDetailsPanel.prototype.focusFirstSection): Deleted.
+        (WI.ComputedStyleDetailsPanel.prototype.focusLastSection): Deleted.
+
 2019-04-02  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js

@@ -77 +77 @@
         if (this._delegate.computedStyleDetailsPanelShowProperty)
             this._delegate.computedStyleDetailsPanelShowProperty(property);
-    }
-
-    focusFirstSection()
-    {
-        this._computedStyleSection.focus();
-    }
-
-    focusLastSection()
-    {
-        this._variablesTextEditor.focus();
     }