Changeset 243847 in webkit


Ignore:
Timestamp:
Apr 3, 2019, 7:53:02 PM (6 years ago)
Author:
Simon Fraser
Message:

Remove the isProgrammaticScroll argument to requestScroll() because no-one uses it
​https://bugs.webkit.org/show_bug.cgi?id=196587

Reviewed by Zalan Bujtas.

This argument was unused.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::requestScroll):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::requestScroll):

  • UIProcess/API/wpe/PageClientImpl.h:
  • UIProcess/PageClient.h:
  • UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestScroll):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::requestScroll):

  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::requestScroll):

  • UIProcess/win/PageClientImpl.cpp:

(WebKit::PageClientImpl::requestScroll):

  • UIProcess/win/PageClientImpl.h:
Location:
trunk/Source/WebKit
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r243841 r243847  
     12019-04-03  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Remove the isProgrammaticScroll argument to requestScroll() because no-one uses it
     4        https://bugs.webkit.org/show_bug.cgi?id=196587
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        This argument was unused.
     9
     10        * UIProcess/API/gtk/PageClientImpl.cpp:
     11        (WebKit::PageClientImpl::requestScroll):
     12        * UIProcess/API/gtk/PageClientImpl.h:
     13        * UIProcess/API/wpe/PageClientImpl.cpp:
     14        (WebKit::PageClientImpl::requestScroll):
     15        * UIProcess/API/wpe/PageClientImpl.h:
     16        * UIProcess/PageClient.h:
     17        * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
     18        (WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
     19        * UIProcess/WebPageProxy.cpp:
     20        (WebKit::WebPageProxy::requestScroll):
     21        * UIProcess/WebPageProxy.h:
     22        * UIProcess/ios/PageClientImplIOS.h:
     23        * UIProcess/ios/PageClientImplIOS.mm:
     24        (WebKit::PageClientImpl::requestScroll):
     25        * UIProcess/mac/PageClientImplMac.h:
     26        * UIProcess/mac/PageClientImplMac.mm:
     27        (WebKit::PageClientImpl::requestScroll):
     28        * UIProcess/win/PageClientImpl.cpp:
     29        (WebKit::PageClientImpl::requestScroll):
     30        * UIProcess/win/PageClientImpl.h:
     31
    1322019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
    233

  • trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp

    r243110 r243847  
    8383}
    8484
    85 void PageClientImpl::requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&, bool)
     85void PageClientImpl::requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&)
    8686{
    8787    notImplemented();

  • trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.h

    r243110 r243847  
    6363    std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy(WebProcessProxy&) override;
    6464    void setViewNeedsDisplay(const WebCore::Region&) override;
    65     void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) override;
     65    void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin) override;
    6666    WebCore::FloatPoint viewScrollPosition() override;
    6767    WebCore::IntSize viewSize() override;

  • trunk/Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp

    r243110 r243847  
    6767}
    6868
    69 void PageClientImpl::requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&, bool)
     69void PageClientImpl::requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&)
    7070{
    7171}

  • trunk/Source/WebKit/UIProcess/API/wpe/PageClientImpl.h

    r243110 r243847  
    6060    std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy(WebProcessProxy&) override;
    6161    void setViewNeedsDisplay(const WebCore::Region&) override;
    62     void requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&, bool) override;
     62    void requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&) override;
    6363    WebCore::FloatPoint viewScrollPosition() override;
    6464    WebCore::IntSize viewSize() override;

  • trunk/Source/WebKit/UIProcess/PageClient.h

    r243110 r243847  
    169169
    170170    // Tell the view to scroll to the given position, and whether this was a programmatic scroll.
    171     virtual void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) = 0;
     171    virtual void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin) = 0;
    172172
    173173    // Return the current scroll position (not necessarily the same as the WebCore scroll position, because of scaling, insets etc.)

  • trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm

    r243094 r243847  
    231231    // has updated the view size based on the content size.
    232232    if (requestedScrollInfo.requestsScrollPositionUpdate)
    233         m_webPageProxy.requestScroll(requestedScrollInfo.requestedScrollPosition, layerTreeTransaction.scrollOrigin(), requestedScrollInfo.requestIsProgrammaticScroll);
     233        m_webPageProxy.requestScroll(requestedScrollInfo.requestedScrollPosition, layerTreeTransaction.scrollOrigin());
    234234#endif // ENABLE(ASYNC_SCROLLING)
    235235

  • trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

    r243809 r243847  
    16191619}
    16201620
    1621 void WebPageProxy::requestScroll(const FloatPoint& scrollPosition, const IntPoint& scrollOrigin, bool isProgrammaticScroll)
    1622 {
    1623     pageClient().requestScroll(scrollPosition, scrollOrigin, isProgrammaticScroll);
     1621void WebPageProxy::requestScroll(const FloatPoint& scrollPosition, const IntPoint& scrollOrigin)
     1622{
     1623    pageClient().requestScroll(scrollPosition, scrollOrigin);
    16241624}
    16251625

  • trunk/Source/WebKit/UIProcess/WebPageProxy.h

    r243797 r243847  
    567567
    568568    void setViewNeedsDisplay(const WebCore::Region&);
    569     void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll);
     569    void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin);
    570570   
    571571    WebCore::FloatPoint viewScrollPosition() const;

  • trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h

    r243110 r243847  
    5757    std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy(WebProcessProxy&) override;
    5858    void setViewNeedsDisplay(const WebCore::Region&) override;
    59     void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) override;
     59    void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin) override;
    6060    WebCore::FloatPoint viewScrollPosition() override;
    6161    WebCore::IntSize viewSize() override;

  • trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm

    r243110 r243847  
    9393}
    9494
    95 void PageClientImpl::requestScroll(const FloatPoint& scrollPosition, const IntPoint& scrollOrigin, bool isProgrammaticScroll)
    96 {
    97     UNUSED_PARAM(isProgrammaticScroll);
     95void PageClientImpl::requestScroll(const FloatPoint& scrollPosition, const IntPoint& scrollOrigin)
     96{
    9897    [m_webView _scrollToContentScrollPosition:scrollPosition scrollOrigin:scrollOrigin];
    9998}

  • trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.h

    r243110 r243847  
    6666    std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy(WebProcessProxy&) override;
    6767    void setViewNeedsDisplay(const WebCore::Region&) override;
    68     void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) override;
     68    void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin) override;
    6969    WebCore::FloatPoint viewScrollPosition() override;
    7070

  • trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.mm

    r243110 r243847  
    133133}
    134134
    135 void PageClientImpl::requestScroll(const FloatPoint& scrollPosition, const IntPoint& scrollOrigin, bool isProgrammaticScroll)
     135void PageClientImpl::requestScroll(const FloatPoint& scrollPosition, const IntPoint& scrollOrigin)
    136136{
    137137}

  • trunk/Source/WebKit/UIProcess/win/PageClientImpl.cpp

    r243110 r243847  
    5555}
    5656
    57 void PageClientImpl::requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&, bool)
     57void PageClientImpl::requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&)
    5858{
    5959    notImplemented();

  • trunk/Source/WebKit/UIProcess/win/PageClientImpl.h

    r243110 r243847  
    6060    std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy(WebProcessProxy&) override;
    6161    void setViewNeedsDisplay(const WebCore::Region&) override;
    62     void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) override;
     62    void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin) override;
    6363    WebCore::FloatPoint viewScrollPosition() override;
    6464    WebCore::IntSize viewSize() override;
Note: See TracChangeset for help on using the changeset viewer.