Changeset 243864 in webkit

Timestamp:

Apr 3, 2019 10:53:30 PM (5 years ago)

Author:

Carlos Garcia Campos

Message:

[ATK] Wrong index passed to AtkObject::children-changed::add signal in AXObjectCache::attachWrapper()
​https://bugs.webkit.org/show_bug.cgi?id=196538

Reviewed by Michael Catanzaro.

In most of the cases the parent is not found, probably because the child is not a direct descendant of the
parent returned by parentObjectUnignored(). We need to handle the case of find() returning notFound.

• accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::attachWrapper): Use -1 as the index when find() returns notFound.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/atk/AXObjectCacheAtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [ATK] Wrong index passed to AtkObject::children-changed::add signal in AXObjectCache::attachWrapper()
+        https://bugs.webkit.org/show_bug.cgi?id=196538
+
+        Reviewed by Michael Catanzaro.
+
+        In most of the cases the parent is not found, probably because the child is not a direct descendant of the
+        parent returned by parentObjectUnignored(). We need to handle the case of find() returning notFound.
+
+        * accessibility/atk/AXObjectCacheAtk.cpp:
+        (WebCore::AXObjectCache::attachWrapper): Use -1 as the index when find() returns notFound.
+
 2019-04-03  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp

@@ -100 +100 @@
 
     size_t index = coreParent->children(false).find(obj);
-    g_signal_emit_by_name(atkParent, "children-changed::add", index, atkObj);
+    g_signal_emit_by_name(atkParent, "children-changed::add", index != notFound ? index : -1, atkObj);
 }