Changeset 243923 in webkit

Timestamp:

Apr 4, 2019 6:09:44 PM (5 years ago)

Author:

rniwa@webkit.org

Message:

Element::isFocusable() debug asserts too frequently
​https://bugs.webkit.org/show_bug.cgi?id=196634

Reviewed by Geoffrey Garen.

Remove the debug assertion for now.

• dom/Element.cpp:

(WebCore::Element::isFocusable const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-04  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Element::isFocusable() debug asserts too frequently
+        https://bugs.webkit.org/show_bug.cgi?id=196634
+
+        Reviewed by Geoffrey Garen.
+
+        Remove the debug assertion for now.
+
+        * dom/Element.cpp:
+        (WebCore::Element::isFocusable const):
+
 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -554 +554 @@
         // If the node is in a display:none tree it might say it needs style recalc but
         // the whole document is actually up to date.
-        ASSERT(!needsStyleRecalc() || !document().childNeedsStyleRecalc());
+        // FIXME: We should be able to assert !needsStyleRecalc() || !document().childNeedsStyleRecalc()
+        // but it hits too frequently on websites like Gmail and Microsoft Exchange.
 
         // Elements in canvas fallback content are not rendered, but they are allowed to be