Changeset 243955 in webkit

Timestamp:

Apr 5, 2019 5:05:32 PM (5 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r243665.

Caused iOS JSC tests to exit with an exception.

Reverted changeset:

"Assertion failed in JSC::createError"
​https://bugs.webkit.org/show_bug.cgi?id=196305
​https://trac.webkit.org/changeset/243665

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/create-error-out-of-memory-rope-string-2.js (deleted)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/ExceptionHelpers.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2019-04-05  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r243665.
+
+        Caused iOS JSC tests to exit with an exception.
+
+        Reverted changeset:
+
+        "Assertion failed in JSC::createError"
+        https://bugs.webkit.org/show_bug.cgi?id=196305
+        https://trac.webkit.org/changeset/243665
+
 2019-04-05  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-04-05  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r243665.
+
+        Caused iOS JSC tests to exit with an exception.
+
+        Reverted changeset:
+
+        "Assertion failed in JSC::createError"
+        https://bugs.webkit.org/show_bug.cgi?id=196305
+        https://trac.webkit.org/changeset/243665
+
 2019-04-05  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp

@@ -276 +276 @@
 
     String valueDescription = errorDescriptionForValue(exec, value);
-    if (scope.exception() || !valueDescription) {
+    ASSERT(scope.exception() || !!valueDescription);
+    if (!valueDescription) {
         scope.clearException();
         return createOutOfMemoryError(exec);