Changeset 244183 in webkit

Timestamp:

Apr 10, 2019 11:08:40 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

REGRESSION (r241734): ⌥⌘↑ and ⌥⌘↓ no longer navigate to previous/next Reading List article
​https://bugs.webkit.org/show_bug.cgi?id=196797
<rdar://problem/48484715>

Reviewed by Simon Fraser.

• UIProcess/ios/WKKeyboardScrollingAnimator.mm:

(-[WKKeyboardScrollingAnimator keyboardScrollForEvent:]):
Validate the set of modifier keys pressed when handling a key event for scrolling:
Ignore key events with multiple modifier keys pressed.
Ignore key events with an invalid modifier key pressed for a given primary key.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKKeyboardScrollingAnimator.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-10  Tim Horton  <timothy_horton@apple.com>
+
+        REGRESSION (r241734): ⌥⌘↑ and ⌥⌘↓ no longer navigate to previous/next Reading List article
+        https://bugs.webkit.org/show_bug.cgi?id=196797
+        <rdar://problem/48484715>
+
+        Reviewed by Simon Fraser.
+
+        * UIProcess/ios/WKKeyboardScrollingAnimator.mm:
+        (-[WKKeyboardScrollingAnimator keyboardScrollForEvent:]):
+        Validate the set of modifier keys pressed when handling a key event for scrolling:
+        Ignore key events with multiple modifier keys pressed.
+        Ignore key events with an invalid modifier key pressed for a given primary key.
+
 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm

@@ -220 +220 @@
     BOOL cmdPressed = event.modifierFlags & WebEventFlagMaskCommandKey;
 
+    // No shortcuts include more than one modifier; we should not eat key events
+    // that contain more than one modifier because they might be used for other shortcuts.
+    if (shiftPressed + altPressed + cmdPressed > 1)
+        return WTF::nullopt;
+
+    auto allowedModifiers = ^ WebEventFlags {
+        switch (key) {
+        case Key::LeftArrow:
+        case Key::RightArrow:
+            return WebEventFlagMaskOptionKey;
+        case Key::UpArrow:
+        case Key::DownArrow:
+            return WebEventFlagMaskOptionKey | WebEventFlagMaskCommandKey;
+        case Key::PageUp:
+        case Key::PageDown:
+            return 0;
+        case Key::Space:
+            return WebEventFlagMaskShiftKey;
+        case Key::Other:
+            ASSERT_NOT_REACHED();
+            return 0;
+        };
+    }();
+
+    if (event.modifierFlags & ~allowedModifiers)
+        return WTF::nullopt;
+
     auto increment = ^{
         switch (key) {