Changeset 244205 in webkit

Timestamp:

Apr 11, 2019 5:58:50 PM (5 years ago)

Author:

Megan Gardner

Message:

Update 'Save Image' to more clear instructions
​https://bugs.webkit.org/show_bug.cgi?id=196833
<rdar://problem/47446845>

Reviewed by Wenson Hsieh.

Source/WebCore:

Not testable, UI change only.

• en.lproj/Localizable.strings:

Source/WebKit:

Just updating to a new string.

• UIProcess/API/Cocoa/_WKElementAction.mm:

(+[_WKElementAction _elementActionWithType:customTitle:assistant:]):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/en.lproj/Localizable.strings (modified) (2 diffs)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/API/Cocoa/_WKElementAction.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-11  Megan Gardner  <megan_gardner@apple.com>
+
+        Update 'Save Image' to more clear instructions
+        https://bugs.webkit.org/show_bug.cgi?id=196833
+        <rdar://problem/47446845>
+
+        Reviewed by Wenson Hsieh.
+
+        Not testable, UI change only.
+
+        * en.lproj/Localizable.strings:
+
 2019-04-11  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/en.lproj/Localizable.strings

@@ -95 +95 @@
 "A JavaScript exception occurred" = "A JavaScript exception occurred";
 
+/* Title for Add to Photos action button */
+"Add to Photos" = "Add to Photos";
+
 /* Title for Add to Reading List action button */
 "Add to Reading List" = "Add to Reading List";
@@ -626 +629 @@
 "Right to Left" = "Right to Left";
 
-/* Title for Save Image action button */
-"Save Image" = "Save Image";
-
 /* Title of the Search button for zoomed form controls. */
 "Search" = "Search";

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-11  Megan Gardner  <megan_gardner@apple.com>
+
+        Update 'Save Image' to more clear instructions
+        https://bugs.webkit.org/show_bug.cgi?id=196833
+        <rdar://problem/47446845>
+
+        Reviewed by Wenson Hsieh.
+
+        Just updating to a new string.
+
+        * UIProcess/API/Cocoa/_WKElementAction.mm:
+        (+[_WKElementAction _elementActionWithType:customTitle:assistant:]):
+
 2019-04-11  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm

@@ -114 +114 @@
         break;
     case _WKElementActionTypeSaveImage:
-        title = WEB_UI_STRING("Save Image", "Title for Save Image action button");
+        title = WEB_UI_STRING("Add to Photos", "Title for Add to Photos action button");
         handler = ^(WKActionSheetAssistant *assistant, _WKActivatedElementInfo *actionInfo) {
             [assistant.delegate actionSheetAssistant:assistant performAction:WebKit::SheetAction::SaveImage];