Changeset 244228 in webkit
- Timestamp:
- Apr 12, 2019, 11:52:01 AM (6 years ago)
- Location:
- trunk
- Files:
-
- 28 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r244227 r244228 4 4 5 5 * platform/win/TestExpectations: 6 7 2019-04-12 Simon Fraser <simon.fraser@apple.com> 8 9 [iOS WK2] Make -webkit-overflow-scrolling be a no-op 10 https://bugs.webkit.org/show_bug.cgi?id=196803 11 rdar://problem/49078202 12 13 Reviewed by Antti Koivisto. 14 15 Rebase some tests, if I thought that non-stacking context overflow was interesting. 16 For others, make overflow be stacking context by adding z-index. 17 Add <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] --> to those that 18 need it. 19 20 * compositing/overflow/scrolling-content-clip-to-viewport.html: 21 * compositing/rtl/rtl-scrolling-with-transformed-descendants.html: 22 * fast/scrolling/ios/change-scrollability-on-content-resize-nested.html: 23 * fast/scrolling/ios/overflow-scroll-inherited-expected.txt: 24 * fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html: 25 * fast/scrolling/ios/overflow-scrolling-ancestor-clip.html: 26 * fast/scrolling/ios/reconcile-layer-position-recursive-expected.txt: 27 * fast/scrolling/ios/reconcile-layer-position-recursive.html: 28 * fast/scrolling/ios/scrolling-content-clip-to-viewport.html: 29 * fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html: 30 * fast/scrolling/ios/touch-scroll-pointer-events-none.html: 31 * fast/scrolling/ios/touch-scroll-visibility-hidden.html: 32 * platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt: 33 * platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt: 34 * scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor.html: 35 * scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed.html: 36 * scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor.html: 37 * scrollingcoordinator/scrolling-tree/coordinated-frame.html: 38 * scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html: 6 39 7 40 2019-04-12 Wenson Hsieh <wenson_hsieh@apple.com> -
trunk/LayoutTests/compositing/overflow/scrolling-content-clip-to-viewport.html
r243347 r244228 8 8 body { 9 9 margin: 0; 10 -webkit-overflow-scrolling: touch;11 10 } 12 11 -
trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt
r243347 r244228 7 7 (bounds 800.00 600.00) 8 8 (contentsOpaque 1) 9 (children 49 (children 1 10 10 (GraphicsLayer 11 11 (position 8.00 8.00) … … 25 25 (bounds 766.00 204.00) 26 26 (drawsContent 1) 27 (children 1 28 (GraphicsLayer 29 (position 462.00 0.00) 30 (anchor 0.00 0.00) 31 (bounds 150.00 200.00) 32 (contentsOpaque 1) 33 ) 34 ) 27 35 ) 28 36 ) 29 )30 )31 )32 (GraphicsLayer33 (offsetFromRenderer width=-250 height=0)34 (position 10.00 10.00)35 (bounds 400.00 204.00)36 (children 137 (GraphicsLayer38 (position 250.00 0.00)39 (bounds 150.00 200.00)40 (contentsOpaque 1)41 )42 )43 )44 (GraphicsLayer45 (offsetFromRenderer width=-96 height=0)46 (position 10.00 10.00)47 (bounds 400.00 204.00)48 (children 149 (GraphicsLayer50 (position 96.00 0.00)51 (anchor 0.00 0.00)52 (bounds 150.00 200.00)53 (contentsOpaque 1)54 )55 )56 )57 (GraphicsLayer58 (offsetFromRenderer width=58 height=0)59 (position 10.00 10.00)60 (bounds 400.00 204.00)61 (children 162 (GraphicsLayer63 (position -58.00 0.00)64 (bounds 150.00 200.00)65 (contentsOpaque 1)66 37 ) 67 38 ) -
trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants.html
r243347 r244228 4 4 <style type="text/css"> 5 5 #scroller { 6 position: relative; 7 z-index: 0; 6 8 overflow-x: auto; 7 9 width: 400px; 8 10 white-space: nowrap; 9 -webkit-overflow-scrolling: touch;10 11 border: 2px solid black; 11 12 } -
trunk/LayoutTests/fast/scrolling/ios/change-scrollability-on-content-resize-nested.html
r243347 r244228 15 15 overflow-x: hidden; 16 16 overflow-y: scroll; 17 -webkit-overflow-scrolling: touch;18 17 position: relative; 18 z-index: 0; 19 19 } 20 20 #content { -
trunk/LayoutTests/fast/scrolling/ios/overflow-scroll-inherited-expected.txt
r200609 r244228 1 test1 -webkit-overflow-scrolling: touch1 test1 -webkit-overflow-scrolling: auto 2 2 test2 -webkit-overflow-scrolling: auto 3 test3 -webkit-overflow-scrolling: touch4 test4 -webkit-overflow-scrolling: touch3 test3 -webkit-overflow-scrolling: auto 4 test4 -webkit-overflow-scrolling: auto 5 5 -
trunk/LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html
r243347 r244228 20 20 <style> 21 21 #scroller { 22 position: relative; 23 z-index: 0; 22 24 overflow: scroll; 23 -webkit-overflow-scrolling: touch;24 25 width: 300px; 25 26 height: 400px; -
trunk/LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip.html
r243347 r244228 20 20 <style> 21 21 #scroller { 22 position: relative; 23 z-index: 0; 22 24 overflow: scroll; 23 -webkit-overflow-scrolling: touch;24 25 width: 300px; 25 26 height: 400px; -
trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive-expected.txt
r240941 r244228 18 18 (top left tile 0, 1 tiles grid 1 x 3) 19 19 (in window 1) 20 (children 120 (children 3 21 21 (GraphicsLayer 22 22 (position 8.00 1008.00) … … 71 71 (intersects coverage rect 1) 72 72 (contentsScale 2.00) 73 (children 274 (GraphicsLayer75 (position 7.00 28.00)76 (approximate position 7.00 28.00)77 (bounds 110.00 110.00)78 (contentsOpaque 1)79 (drawsContent 1)80 (visible rect 0.00, 0.00 110.00 x 110.00)81 (coverage rect -7.00, -28.00 200.00 x 245.00)82 (intersects coverage rect 1)83 (contentsScale 2.00)84 (children 185 (GraphicsLayer86 (position 55.00 55.00)87 (approximate position 55.00 55.00)88 (bounds 110.00 110.00)89 (contentsOpaque 1)90 (drawsContent 1)91 (visible rect 0.00, 0.00 110.00 x 110.00)92 (coverage rect -62.00, -83.00 200.00 x 245.00)93 (intersects coverage rect 1)94 (contentsScale 2.00)95 )96 )97 )98 (GraphicsLayer99 (position 105.00 395.00)100 (approximate position 105.00 395.00)101 (bounds 110.00 110.00)102 (contentsOpaque 1)103 (drawsContent 1)104 (visible rect 0.00, 0.00 0.00 x 0.00)105 (coverage rect -105.00, -395.00 200.00 x 245.00)106 (intersects coverage rect 1)107 (contentsScale 2.00)108 (children 1109 (GraphicsLayer110 (position 55.00 55.00)111 (approximate position 55.00 55.00)112 (bounds 110.00 110.00)113 (contentsOpaque 1)114 (drawsContent 1)115 (visible rect 0.00, 0.00 0.00 x 0.00)116 (coverage rect -160.00, -450.00 200.00 x 245.00)117 (intersects coverage rect 1)118 (contentsScale 2.00)119 )120 )121 )122 )123 73 ) 124 74 ) … … 132 82 ) 133 83 ) 84 (GraphicsLayer 85 (position 70.00 1091.00) 86 (approximate position 70.00 1091.00) 87 (bounds 110.00 110.00) 88 (contentsOpaque 1) 89 (drawsContent 1) 90 (visible rect 0.00, 0.00 110.00 x 110.00) 91 (coverage rect -70.00, -326.00 1056.00 x 856.00) 92 (intersects coverage rect 1) 93 (contentsScale 2.00) 94 (children 1 95 (GraphicsLayer 96 (position 55.00 55.00) 97 (approximate position 55.00 55.00) 98 (bounds 110.00 110.00) 99 (contentsOpaque 1) 100 (drawsContent 1) 101 (visible rect 0.00, 0.00 110.00 x 110.00) 102 (coverage rect -125.00, -381.00 1056.00 x 856.00) 103 (intersects coverage rect 1) 104 (contentsScale 2.00) 105 ) 106 ) 107 ) 108 (GraphicsLayer 109 (offsetFromRenderer width=-105 height=-105) 110 (position 63.00 1063.00) 111 (bounds 200.00 245.00) 112 (visible rect 0.00, 0.00 200.00 x 245.00) 113 (coverage rect 0.00, 0.00 200.00 x 245.00) 114 (intersects coverage rect 1) 115 (contentsScale 2.00) 116 (children 1 117 (GraphicsLayer 118 (position 105.00 395.00) 119 (approximate position 105.00 395.00) 120 (bounds 110.00 110.00) 121 (contentsOpaque 1) 122 (drawsContent 1) 123 (visible rect 0.00, 0.00 0.00 x 0.00) 124 (coverage rect -105.00, -395.00 200.00 x 245.00) 125 (intersects coverage rect 1) 126 (contentsScale 2.00) 127 (children 1 128 (GraphicsLayer 129 (position 55.00 55.00) 130 (approximate position 55.00 55.00) 131 (bounds 110.00 110.00) 132 (contentsOpaque 1) 133 (drawsContent 1) 134 (visible rect 0.00, 0.00 0.00 x 0.00) 135 (coverage rect -160.00, -450.00 200.00 x 245.00) 136 (intersects coverage rect 1) 137 (contentsScale 2.00) 138 ) 139 ) 140 ) 141 ) 142 ) 134 143 ) 135 144 ) -
trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive.html
r243347 r244228 12 12 background: linear-gradient(135deg, cyan, green); 13 13 overflow: auto; 14 -webkit-overflow-scrolling: touch;15 14 } 16 15 .fixed { -
trunk/LayoutTests/fast/scrolling/ios/scrolling-content-clip-to-viewport.html
r243347 r244228 7 7 body { 8 8 margin: 0; 9 -webkit-overflow-scrolling: touch;10 9 } 11 10 -
trunk/LayoutTests/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html
r243347 r244228 20 20 <style> 21 21 #scroller { 22 position: relative; 23 z-index: 0; 22 24 overflow: scroll; 23 -webkit-overflow-scrolling: touch;24 25 width: 300px; 25 26 height: 400px; -
trunk/LayoutTests/fast/scrolling/ios/touch-scroll-pointer-events-none.html
r243347 r244228 26 26 .container { 27 27 position: absolute; 28 z-index: 0; 28 29 top: 50px; 29 30 left: 50px; … … 31 32 width: 300px; 32 33 overflow: scroll; 33 -webkit-overflow-scrolling: touch;34 34 border: 1px solid black; 35 35 pointer-events: none; -
trunk/LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden.html
r216145 r244228 1 <!DOCTYPE html> 2 1 <!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] --> 3 2 <html> 4 3 <head> … … 27 26 .container { 28 27 position: absolute; 28 z-index: 0; 29 29 top: 50px; 30 30 left: 50px; … … 32 32 width: 300px; 33 33 overflow: scroll; 34 -webkit-overflow-scrolling: touch;35 34 border: 1px solid black; 36 35 visibility: hidden; -
trunk/LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt
r240713 r244228 6 6 (bounds 800.00 600.00) 7 7 (contentsOpaque 1) 8 (children 18 (children 2 9 9 (GraphicsLayer 10 10 (bounds 320.00 340.00) … … 16 16 (anchor 0.00 0.00) 17 17 (bounds 320.00 1224.00) 18 (drawsContent 1)19 18 ) 20 19 ) 20 ) 21 ) 22 ) 23 (GraphicsLayer 24 (offsetFromRenderer width=-10 height=-10) 25 (bounds 320.00 340.00) 26 (children 1 27 (GraphicsLayer 28 (position 10.00 10.00) 29 (bounds 284.00 1204.00) 30 (contentsOpaque 1) 31 (drawsContent 1) 21 32 ) 22 33 ) -
trunk/LayoutTests/platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt
r240713 r244228 6 6 (bounds 320.00 548.00) 7 7 (contentsOpaque 1) 8 (children 18 (children 2 9 9 (GraphicsLayer 10 10 (bounds 320.00 340.00) … … 16 16 (anchor 0.00 0.00) 17 17 (bounds 320.00 1224.00) 18 (drawsContent 1)19 18 ) 20 19 ) 20 ) 21 ) 22 ) 23 (GraphicsLayer 24 (offsetFromRenderer width=-10 height=-10) 25 (bounds 320.00 340.00) 26 (children 1 27 (GraphicsLayer 28 (position 10.00 10.00) 29 (bounds 284.00 1204.00) 30 (contentsOpaque 1) 31 (drawsContent 1) 21 32 ) 22 33 ) -
trunk/LayoutTests/platform/mac-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt
r243361 r244228 9 9 (children 1 10 10 (GraphicsLayer 11 (offsetFromRenderer width=-96 height=0) 12 (position 10.00 10.00) 13 (bounds 400.00 204.00) 11 (position 8.00 8.00) 12 (bounds 404.00 223.00) 14 13 (children 1 15 14 (GraphicsLayer 16 (position 96.00 0.00) 17 (anchor 0.00 0.00) 18 (bounds 150.00 200.00) 19 (contentsOpaque 1) 15 (offsetFromRenderer width=2 height=2) 16 (position 2.00 2.00) 17 (bounds 400.00 204.00) 18 (children 1 19 (GraphicsLayer 20 (position 96.00 0.00) 21 (anchor 0.00 0.00) 22 (bounds 150.00 200.00) 23 (contentsOpaque 1) 24 ) 25 ) 20 26 ) 21 27 ) -
trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt
r241934 r244228 13 13 (min layout viewport origin (0,0)) 14 14 (max layout viewport origin (0,416)) 15 (synchronous event dispatch region for event wheel16 at (45,47) size 404x304)17 15 (behavior for fixed 0) 18 16 (children 1 … … 34 32 (max layout viewport origin (0,120)) 35 33 (behavior for fixed 0) 36 (children 1 34 (children 2 35 (Overflow scrolling node 36 (scrollable area size 385 285) 37 (contents size 385 1760) 38 (parent relative scrollable rect at (10,10) size 385x285) 39 (scrollable area parameters 40 (horizontal scroll elasticity 0) 41 (vertical scroll elasticity 0) 42 (horizontal scrollbar mode 0) 43 (vertical scrollbar mode 0) 44 (has enabled vertical scrollbar 1)) 45 (children 1 46 (Sticky node 47 (anchor edges: AnchorEdgeTop AnchorEdgeBottom) 48 (top offset 10.00) 49 (bottom offset 10.00) 50 (containing block rect at (2,2) size 385x1760) 51 (sticky box rect at (0,830) size 100x100) 52 (constraining rect at (0,0) size 385x285) 53 (sticky offset at last layout width=0 height=-655) 54 (layer position at last layout (0,175)) 55 ) 56 ) 57 ) 37 58 (Sticky node 38 59 (anchor edges: AnchorEdgeTop AnchorEdgeBottom) -
trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt
r241934 r244228 13 13 (min layout viewport origin (0,0)) 14 14 (max layout viewport origin (0,416)) 15 (synchronous event dispatch region for event wheel16 at (45,47) size 404x304)17 15 (behavior for fixed 0) 18 16 (children 1 … … 38 36 (max layout viewport origin (0,120)) 39 37 (behavior for fixed 0) 40 (children 1 38 (children 2 39 (Overflow scrolling node 40 (scrollable area size 385 285) 41 (contents size 385 1760) 42 (parent relative scrollable rect at (10,10) size 385x285) 43 (scrollable area parameters 44 (horizontal scroll elasticity 0) 45 (vertical scroll elasticity 0) 46 (horizontal scrollbar mode 0) 47 (vertical scrollbar mode 0) 48 (has enabled vertical scrollbar 1)) 49 (children 1 50 (Sticky node 51 (anchor edges: AnchorEdgeTop AnchorEdgeBottom) 52 (top offset 10.00) 53 (bottom offset 10.00) 54 (containing block rect at (2,2) size 385x1760) 55 (sticky box rect at (0,830) size 100x100) 56 (constraining rect at (0,0) size 385x285) 57 (sticky offset at last layout width=0 height=-655) 58 (layer position at last layout (0,175)) 59 ) 60 ) 61 ) 41 62 (Sticky node 42 63 (anchor edges: AnchorEdgeTop AnchorEdgeBottom) -
trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor.html
r240505 r244228 1 <!DOCTYPE html> 1 <!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] --> 2 2 <html> 3 3 <head> -
trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt
r241934 r244228 13 13 (min layout viewport origin (0,0)) 14 14 (max layout viewport origin (0,416)) 15 (synchronous event dispatch region for event wheel16 at (45,37) size 404x304)17 15 (behavior for fixed 0) 18 16 (children 1 … … 39 37 (max layout viewport origin (0,120)) 40 38 (behavior for fixed 0) 41 (children 1 39 (children 2 40 (Overflow scrolling node 41 (scrollable area size 385 285) 42 (contents size 385 1760) 43 (parent relative scrollable rect at (10,10) size 385x285) 44 (scrollable area parameters 45 (horizontal scroll elasticity 0) 46 (vertical scroll elasticity 0) 47 (horizontal scrollbar mode 0) 48 (vertical scrollbar mode 0) 49 (has enabled vertical scrollbar 1)) 50 (children 1 51 (Sticky node 52 (anchor edges: AnchorEdgeTop AnchorEdgeBottom) 53 (top offset 10.00) 54 (bottom offset 10.00) 55 (containing block rect at (2,2) size 385x1760) 56 (sticky box rect at (0,830) size 100x100) 57 (constraining rect at (0,0) size 385x285) 58 (sticky offset at last layout width=0 height=-655) 59 (layer position at last layout (0,175)) 60 ) 61 ) 62 ) 42 63 (Sticky node 43 64 (anchor edges: AnchorEdgeTop AnchorEdgeBottom) -
trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed.html
r240505 r244228 1 <!DOCTYPE html> 1 <!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] --> 2 2 <html> 3 3 <head> -
trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt
r241934 r244228 13 13 (min layout viewport origin (0,0)) 14 14 (max layout viewport origin (0,416)) 15 (synchronous event dispatch region for event wheel16 at (45,47) size 404x304)17 15 (behavior for fixed 0) 18 16 (children 1 … … 33 31 (max layout viewport origin (0,120)) 34 32 (behavior for fixed 0) 35 (children 1 33 (children 2 34 (Overflow scrolling node 35 (scrollable area size 385 285) 36 (contents size 385 1760) 37 (parent relative scrollable rect at (10,10) size 385x285) 38 (scrollable area parameters 39 (horizontal scroll elasticity 0) 40 (vertical scroll elasticity 0) 41 (horizontal scrollbar mode 0) 42 (vertical scrollbar mode 0) 43 (has enabled vertical scrollbar 1)) 44 (children 1 45 (Sticky node 46 (anchor edges: AnchorEdgeTop AnchorEdgeBottom) 47 (top offset 10.00) 48 (bottom offset 10.00) 49 (containing block rect at (2,2) size 385x1760) 50 (sticky box rect at (0,830) size 100x100) 51 (constraining rect at (0,0) size 385x285) 52 (sticky offset at last layout width=0 height=-655) 53 (layer position at last layout (0,175)) 54 ) 55 ) 56 ) 36 57 (Sticky node 37 58 (anchor edges: AnchorEdgeTop AnchorEdgeBottom) -
trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor.html
r240505 r244228 1 <!DOCTYPE html> 1 <!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] --> 2 2 <html> 3 3 <head> -
trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame.html
r240505 r244228 1 <!DOCTYPE html> 1 <!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] --> 2 2 <html> 3 3 <head> -
trunk/LayoutTests/scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html
r243347 r244228 10 10 11 11 .scrolling { 12 position: relative; 13 z-index: 0; 12 14 height: 300px; 13 15 width: 400px; 14 16 overflow: scroll; 15 -webkit-overflow-scrolling: touch;16 17 border: 2px solid black; 17 18 } -
trunk/Source/WebKit/ChangeLog
r244225 r244228 59 59 * UIProcess/API/APIWebsitePolicies.cpp: 60 60 (API::WebsitePolicies::copy const): 61 62 2019-04-12 Simon Fraser <simon.fraser@apple.com> 63 64 [iOS WK2] Make -webkit-overflow-scrolling be a no-op 65 https://bugs.webkit.org/show_bug.cgi?id=196803 66 rdar://problem/49078202 67 68 Reviewed by Antti Koivisto. 69 70 Flip LegacyOverflowScrollingTouchEnabled to false. 71 72 * Shared/WebPreferences.yaml: 61 73 62 74 2019-04-12 Wenson Hsieh <wenson_hsieh@apple.com> -
trunk/Source/WebKit/Shared/WebPreferences.yaml
r244203 r244228 1454 1454 LegacyOverflowScrollingTouchEnabled: 1455 1455 type: bool 1456 defaultValue: true1456 defaultValue: false 1457 1457 humanReadableName: "Legacy -webkit-overflow-scrolling property" 1458 1458 humanReadableDescription: "Support the legacy -webkit-overflow-scrolling CSS property"
Note:
See TracChangeset
for help on using the changeset viewer.