Changeset 244240 in webkit

Timestamp:

Apr 13, 2019 1:00:44 AM (5 years ago)

Author:

graouts@webkit.org

Message:

Provide a quirk to disable Pointer Events
​https://bugs.webkit.org/show_bug.cgi?id=196877
<rdar://problem/49863470>

Reviewed by Dean Jackson.

Add a quirk to disable Pointer Events. We also opt a website that has compatibility issues with Pointer Events into this new quirk.

• dom/PointerEvent.idl:
• page/Quirks.cpp:

(WebCore::Quirks::shouldDisablePointerEventsQuirk const):

• page/Quirks.h:
• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const):

• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/PointerEvent.idl (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)
• page/Quirks.h (modified) (1 diff)
• page/scrolling/ScrollingCoordinator.cpp (modified) (1 diff)
• style/StyleTreeResolver.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-12  Antoine Quint  <graouts@apple.com>
+
+        Provide a quirk to disable Pointer Events
+        https://bugs.webkit.org/show_bug.cgi?id=196877
+        <rdar://problem/49863470>
+
+        Reviewed by Dean Jackson.
+
+        Add a quirk to disable Pointer Events. We also opt a website that has compatibility issues with Pointer Events into this new quirk.
+
+        * dom/PointerEvent.idl:
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldDisablePointerEventsQuirk const):
+        * page/Quirks.h:
+        * page/scrolling/ScrollingCoordinator.cpp:
+        (WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const):
+        * style/StyleTreeResolver.cpp:
+        (WebCore::Style::TreeResolver::resolveElement):
+
 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/dom/PointerEvent.idl

@@ -40 +40 @@
     Conditional=POINTER_EVENTS,
     EnabledAtRuntime=PointerEvents,
+    DisabledByQuirk=shouldDisablePointerEvents,
     Constructor(DOMString type, optional PointerEventInit eventInitDict),
     Exposed=Window

trunk/Source/WebCore/page/Quirks.cpp

@@ -229 +229 @@
 }
 
-}
+bool Quirks::shouldDisablePointerEventsQuirk() const
+{
+#if PLATFORM(IOS_FAMILY)
+    if (!needsQuirks())
+        return false;
+
+    auto& url = m_document->topDocument().url();
+    auto host = url.host();
+    if (equalLettersIgnoringASCIICase(host, "mailchimp.com") || host.endsWithIgnoringASCIICase(".mailchimp.com"))
+        return true;
+#endif
+    return false;
+}
+
+}

trunk/Source/WebCore/page/Quirks.h

@@ -47 +47 @@
     bool hasWebSQLSupportQuirk() const;
     bool shouldDispatchSimulatedMouseEvents() const;
+    bool shouldDisablePointerEventsQuirk() const;
 
     WEBCORE_EXPORT bool isTouchBarUpdateSupressedForHiddenContentEditable() const;

trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

@@ -112 +112 @@
 
 #if ENABLE(POINTER_EVENTS)
-    if (RuntimeEnabledFeatures::sharedFeatures().pointerEventsEnabled()) {
+    if (!document->quirks().shouldDisablePointerEventsQuirk() && RuntimeEnabledFeatures::sharedFeatures().pointerEventsEnabled()) {
         if (auto* touchActionElements = frame.document()->touchActionElements()) {
             auto& touchActionData = eventTrackingRegions.touchActionData;

trunk/Source/WebCore/style/StyleTreeResolver.cpp

@@ -43 +43 @@
 #include "Page.h"
 #include "PlatformStrategies.h"
+#include "Quirks.h"
 #include "RenderElement.h"
 #include "RenderStyle.h"
@@ -239 +240 @@
 
 #if ENABLE(POINTER_EVENTS) && PLATFORM(IOS_FAMILY)
-    if (RuntimeEnabledFeatures::sharedFeatures().pointerEventsEnabled())
+    if (!m_document.quirks().shouldDisablePointerEventsQuirk() && RuntimeEnabledFeatures::sharedFeatures().pointerEventsEnabled())
         m_document.updateTouchActionElements(element, *update.style.get());
 #endif