Changeset 244247 in webkit


Ignore:
Timestamp:
Apr 14, 2019 1:14:19 PM (5 years ago)
Author:
dino@apple.com
Message:

Extract UTI mapping and allow for additions
https://bugs.webkit.org/show_bug.cgi?id=196822
<rdar://problem/49822339>

Reviewed by Darin Adler

Post landing feedback on minimizing String constructors.

  • platform/network/mac/UTIUtilities.mm:

(WebCore::MIMETypeFromUTITree):
(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r244245 r244247  
     12019-04-14  Dean Jackson  <dino@apple.com>
     2
     3        Extract UTI mapping and allow for additions
     4        https://bugs.webkit.org/show_bug.cgi?id=196822
     5        <rdar://problem/49822339>
     6
     7        Reviewed by Darin Adler
     8
     9        Post landing feedback on minimizing String constructors.
     10
     11        * platform/network/mac/UTIUtilities.mm:
     12        (WebCore::MIMETypeFromUTITree):
     13        (WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
     14
    1152019-04-14  Don Olmstead  <don.olmstead@sony.com>
    216
  • trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm

    r244201 r244247  
    5959    RetainPtr<CFDictionaryRef> decl = adoptCF(UTTypeCopyDeclaration(utiCF.get()));
    6060    if (!decl)
    61         return String();
     61        return emptyString();
    6262    CFTypeRef value = CFDictionaryGetValue(decl.get(), kUTTypeConformsToKey);
    6363    if (!value)
    64         return String();
     64        return emptyString();
    6565    CFTypeID typeID = CFGetTypeID(value);
    6666
     
    8282    }
    8383
    84     return String();
     84    return emptyString();
    8585}
    8686
     
    119119        auto type = adoptCF(UTTypeCreatePreferredIdentifierForTag(kUTTagClassMIMEType, key.createCFString().get(), 0));
    120120        if (type)
    121             return String(type.get());
     121            return type.get();
    122122        return UTIFromUnknownMIMEType(key);
    123123    }
Note: See TracChangeset for help on using the changeset viewer.