Changeset 244280 in webkit

Timestamp:

Apr 15, 2019 12:46:34 PM (5 years ago)

Author:

Devin Rousso

Message:

REGRESSION (r240644): Layout Test inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=194437
<rdar://problem/48008005>

Reviewed by Joseph Pecoraro.

• inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
• inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt (modified) (1 diff)
• inspector/page/overrideSetting-ICECandidateFilteringEnabled.html (modified) (6 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-04-15  Devin Rousso  <drousso@apple.com>
+
+        REGRESSION (r240644): Layout Test inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=194437
+        <rdar://problem/48008005>
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
+        * inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:
+
 2019-04-15  Said Abou-Hallawa  <said@apple.com>
 

trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt

@@ -4 +4 @@
 == Running test suite: Page.overrideSetting
 -- Running test case: Page.overrideSetting.ICECandidateFilteringEnabled
-PASS: created offer
-PASS: Should not be able to establish a connection when filtering ice candidates.
 Overriding ICECandidateFilteringEnabled to false...
+Creating data channel...
 PASS: created offer
 PASS: received ICE candidate.
 PASS: Should be able to establish a connection when filtering ice candidates.
 Removing ICECandidateFilteringEnabled override...
+Creating data channel...
 PASS: created offer
 PASS: Should not be able to establish a connection when filtering ice candidates.

trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html

@@ -13 +13 @@
     let dc = null;
 
-    let pc = new RTCPeerConnection();
+    let pc = new RTCPeerConnection;
     pc.onicecandidate = (event) => {
         if (event.candidate) {
@@ -22 +22 @@
         }
 
+        TestPage.dispatchEventToFrontend("DataChannel", {success: !!receivedCandidate});
+
         delete pc.onicecandidate;
         pc.close();
         dc.close();
-
-        if (receivedCandidate) {
-            TestPage.dispatchEventToFrontend("DataChannel", {success: true});
-        } else
-            TestPage.dispatchEventToFrontend("DataChannel", {success: false});
     };
 
+    TestPage.addResult("Creating data channel...");
     dc = pc.createDataChannel("sendDataChannel");
 
@@ -46 +44 @@
 function test()
 {
+    InspectorTest.debug();
+
     let suite = InspectorTest.createAsyncSuite("Page.overrideSetting");
 
@@ -52 +52 @@
         description: "Test that changing whether ice candidate filtering is enabled has an effect.",
         async test() {
-            let [defaultResult] = await Promise.all([
-                InspectorTest.awaitEvent("DataChannel"),
-                InspectorTest.evaluateInPage(`createDataChannel()`),
-            ]);
-            InspectorTest.expectFalse(defaultResult.data.success, "Should not be able to establish a connection when filtering ice candidates.");
-
             InspectorTest.log("Overriding ICECandidateFilteringEnabled to false...");
             await PageAgent.overrideSetting(PageAgent.Setting.ICECandidateFilteringEnabled, false);
@@ -65 +59 @@
                 InspectorTest.evaluateInPage(`createDataChannel()`),
             ])
-            InspectorTest.expectFalse(defaultResult.data.success, "Should be able to establish a connection when filtering ice candidates.");
+            InspectorTest.expectThat(overriddenResult.data.success, "Should be able to establish a connection when filtering ice candidates.");
 
             InspectorTest.log("Removing ICECandidateFilteringEnabled override...");
@@ -74 +68 @@
                 InspectorTest.evaluateInPage(`createDataChannel()`),
             ])
-            InspectorTest.expectFalse(defaultResult.data.success, "Should not be able to establish a connection when filtering ice candidates.");
+            InspectorTest.expectFalse(originalResult.data.success, "Should not be able to establish a connection when filtering ice candidates.");
         },
     });