Changeset 244353 in webkit


Ignore:
Timestamp:
Apr 16, 2019 12:48:37 PM (5 years ago)
Author:
Devin Rousso
Message:

Unprefix -webkit-sticky
​https://bugs.webkit.org/show_bug.cgi?id=196962
<rdar://problem/40903458>

Reviewed by Simon Fraser.

Source/WebCore:

Updated existing tests.

This change doesn't modify functionality, only exposing a new unprefixed CSS value.

  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator PositionType const):

  • css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::convertPositionStyle):

Source/WebInspectorUI:

Replace all -webkit-sticky with sticky.

  • UserInterface/Models/CSSKeywordCompletions.js:
  • UserInterface/Views/AuditTestCaseContentView.css:

(.content-view-container > .content-view.audit-test-case > header):

  • UserInterface/Views/AuditTestGroupContentView.css:

(.content-view.audit-test-group.contains-test-case > header):

  • UserInterface/Views/ChangesDetailsSidebarPanel.css:

(.changes-panel .resource-section > .header):

  • UserInterface/Views/DetailsSection.css:

(.details-section > .header):

  • UserInterface/Views/NetworkDetailView.css:

(.network-detail .navigation-bar):

  • UserInterface/Views/SettingsTabContentView.css:

(.content-view.settings .navigation-bar):

  • UserInterface/Views/Table.css:

(.table > .header):

LayoutTests:

  • compositing/layer-creation/no-compositing-for-sticky.html:
  • editing/pasteboard/copy-paste-converts-sticky.html:
  • editing/pasteboard/copy-paste-converts-sticky-expected.txt:
  • fast/block/positioning/fixed-container-with-sticky-parent.html:
  • fast/block/sticky-position-containing-block-crash.html:
  • fast/css/sticky/inflow-sticky.html:
  • fast/css/sticky/inline-sticky-abspos-child.html:
  • fast/css/sticky/inline-sticky.html:
  • fast/css/sticky/multiple-layers-sticky-crash.html:
  • fast/css/sticky/parsing-position-sticky-expected.txt:
  • fast/css/sticky/remove-inline-sticky-crash.html:
  • fast/css/sticky/remove-sticky-crash.html:
  • fast/css/sticky/replaced-sticky.html:
  • fast/css/sticky/resources/parsing-position-sticky.js:
  • fast/css/sticky/sticky-as-positioning-container.html:
  • fast/css/sticky/sticky-both-sides.html:
  • fast/css/sticky/sticky-bottom-overflow-padding.html:
  • fast/css/sticky/sticky-left-percentage.html:
  • fast/css/sticky/sticky-left.html:
  • fast/css/sticky/sticky-margins.html:
  • fast/css/sticky/sticky-overflowing.html:
  • fast/css/sticky/sticky-side-margins.html:
  • fast/css/sticky/sticky-stacking-context.html:
  • fast/css/sticky/sticky-stacking-context-expected.html:
  • fast/css/sticky/sticky-table-row-top.html:
  • fast/css/sticky/sticky-table-thead-top.html:
  • fast/css/sticky/sticky-top-margins.html:
  • fast/css/sticky/sticky-top-overflow-container-overflow.html:
  • fast/css/sticky/sticky-top-overflow.html:
  • fast/css/sticky/sticky-top-zoomed.html:
  • fast/css/sticky/sticky-top-zoomed-expected.html:
  • fast/css/sticky/sticky-top.html:
  • fast/css/sticky/sticky-writing-mode-horizontal-bt.html:
  • fast/css/sticky/sticky-writing-mode-vertical-lr.html:
  • fast/css/sticky/sticky-writing-mode-vertical-rl.html:
  • fast/multicol/newmulticol/table-section-crash.html:
  • fast/scrolling/ios/reconcile-layer-position-recursive.html:
  • fast/scrolling/rtl-scrollbars-sticky-document-2.html:
  • fast/scrolling/rtl-scrollbars-sticky-document.html:
  • fast/scrolling/rtl-scrollbars-sticky-iframe-2.html:
  • fast/scrolling/rtl-scrollbars-sticky-iframe.html:
  • fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html:
  • fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html:
  • fast/scrolling/sticky-to-fixed.html:
  • legacy-animation-engine/fast/multicol/newmulticol/table-section-crash.html:
  • scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html:
  • svg/text/select-text-inside-non-static-position.html:
  • tiled-drawing/scrolling/sticky/negative-scroll-offset.html:
  • tiled-drawing/scrolling/sticky/sticky-horizontal.html:
  • tiled-drawing/scrolling/sticky/sticky-layers.html:
  • tiled-drawing/scrolling/sticky/sticky-vertical.html:
Location:
trunk
Files:
67 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r244346 r244353  
     12019-04-16  Devin Rousso  <drousso@apple.com>
     2
     3        Unprefix -webkit-sticky
     4        https://bugs.webkit.org/show_bug.cgi?id=196962
     5        <rdar://problem/40903458>
     6
     7        Reviewed by Simon Fraser.
     8
     9        * compositing/layer-creation/no-compositing-for-sticky.html:
     10        * editing/pasteboard/copy-paste-converts-sticky.html:
     11        * editing/pasteboard/copy-paste-converts-sticky-expected.txt:
     12        * fast/block/positioning/fixed-container-with-sticky-parent.html:
     13        * fast/block/sticky-position-containing-block-crash.html:
     14        * fast/css/sticky/inflow-sticky.html:
     15        * fast/css/sticky/inline-sticky-abspos-child.html:
     16        * fast/css/sticky/inline-sticky.html:
     17        * fast/css/sticky/multiple-layers-sticky-crash.html:
     18        * fast/css/sticky/parsing-position-sticky-expected.txt:
     19        * fast/css/sticky/remove-inline-sticky-crash.html:
     20        * fast/css/sticky/remove-sticky-crash.html:
     21        * fast/css/sticky/replaced-sticky.html:
     22        * fast/css/sticky/resources/parsing-position-sticky.js:
     23        * fast/css/sticky/sticky-as-positioning-container.html:
     24        * fast/css/sticky/sticky-both-sides.html:
     25        * fast/css/sticky/sticky-bottom-overflow-padding.html:
     26        * fast/css/sticky/sticky-left-percentage.html:
     27        * fast/css/sticky/sticky-left.html:
     28        * fast/css/sticky/sticky-margins.html:
     29        * fast/css/sticky/sticky-overflowing.html:
     30        * fast/css/sticky/sticky-side-margins.html:
     31        * fast/css/sticky/sticky-stacking-context.html:
     32        * fast/css/sticky/sticky-stacking-context-expected.html:
     33        * fast/css/sticky/sticky-table-row-top.html:
     34        * fast/css/sticky/sticky-table-thead-top.html:
     35        * fast/css/sticky/sticky-top-margins.html:
     36        * fast/css/sticky/sticky-top-overflow-container-overflow.html:
     37        * fast/css/sticky/sticky-top-overflow.html:
     38        * fast/css/sticky/sticky-top-zoomed.html:
     39        * fast/css/sticky/sticky-top-zoomed-expected.html:
     40        * fast/css/sticky/sticky-top.html:
     41        * fast/css/sticky/sticky-writing-mode-horizontal-bt.html:
     42        * fast/css/sticky/sticky-writing-mode-vertical-lr.html:
     43        * fast/css/sticky/sticky-writing-mode-vertical-rl.html:
     44        * fast/multicol/newmulticol/table-section-crash.html:
     45        * fast/scrolling/ios/reconcile-layer-position-recursive.html:
     46        * fast/scrolling/rtl-scrollbars-sticky-document-2.html:
     47        * fast/scrolling/rtl-scrollbars-sticky-document.html:
     48        * fast/scrolling/rtl-scrollbars-sticky-iframe-2.html:
     49        * fast/scrolling/rtl-scrollbars-sticky-iframe.html:
     50        * fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html:
     51        * fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html:
     52        * fast/scrolling/sticky-to-fixed.html:
     53        * legacy-animation-engine/fast/multicol/newmulticol/table-section-crash.html:
     54        * scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html:
     55        * svg/text/select-text-inside-non-static-position.html:
     56        * tiled-drawing/scrolling/sticky/negative-scroll-offset.html:
     57        * tiled-drawing/scrolling/sticky/sticky-horizontal.html:
     58        * tiled-drawing/scrolling/sticky/sticky-layers.html:
     59        * tiled-drawing/scrolling/sticky/sticky-vertical.html:
     60
    1612019-04-16  John Wilander  <wilander@apple.com>
    262

  • trunk/LayoutTests/compositing/layer-creation/no-compositing-for-sticky.html

    r190060 r244353  
    2626   
    2727    .sticky {
    28       position: -webkit-sticky;
     28      position: sticky;
    2929      display: inline-block;
    3030      background: silver;

  • trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-expected.txt

    r164299 r244353  
    2222abc"
    2323|     <div>
    24 |       style="position: -webkit-sticky; left: 0px; top: 0px;"
     24|       style="position: sticky; left: 0px; top: 0px;"
    2525|       "def"
    2626|     "ghi

  • trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky.html

    r164299 r244353  
    55</head>
    66<body>
    7 abc<div style="position: -webkit-sticky; left: 0px; top: 0px;">def</div>ghi
     7abc<div style="position: sticky; left: 0px; top: 0px;">def</div>ghi
    88<br/>
    99

  • trunk/LayoutTests/fast/block/positioning/fixed-container-with-sticky-parent.html

    r194710 r244353  
    99</head>
    1010<body>
    11 <div style="position: -webkit-sticky; left: 50px; width: 20px; height: 20px; border: 1px solid green;">
     11<div style="position: sticky; left: 50px; width: 20px; height: 20px; border: 1px solid green;">
    1212  <div class=fixed style="width: 20px; height: 20px; background-color: green;"></div>
    1313</div>
    14 <div style="position: -webkit-sticky; left: 50px; width: 20px; height: 20px; margin: 5px; border: 1px solid green;">
     14<div style="position: sticky; left: 50px; width: 20px; height: 20px; margin: 5px; border: 1px solid green;">
    1515  <div class=fixed style="width: 20px; height: 20px; background-color: green;"></div>
    1616</div>

  • trunk/LayoutTests/fast/block/sticky-position-containing-block-crash.html

    r138908 r244353  
    88      <i>
    99        <i>
    10           <i style="position: -webkit-sticky; display: table-footer-group;">
     10          <i style="position: sticky; display: table-footer-group;">
    1111            <span></span>
    1212          </i>

  • trunk/LayoutTests/fast/css/sticky/inflow-sticky.html

    r180441 r244353  
    3838    .sticky {
    3939        background-color: green;
    40         position: -webkit-sticky;
     40        position: sticky;
    4141        top: 300px;
    4242    }

  • trunk/LayoutTests/fast/css/sticky/inline-sticky-abspos-child.html

    r180441 r244353  
    3535        height: 200px;
    3636        color: blue;
    37         position: -webkit-sticky;
     37        position: sticky;
    3838        top: 100px;
    3939    }

  • trunk/LayoutTests/fast/css/sticky/inline-sticky.html

    r180441 r244353  
    3535        height: 200px;
    3636        color: blue;
    37         position: -webkit-sticky;
     37        position: sticky;
    3838        top: 100px;
    3939    }

  • trunk/LayoutTests/fast/css/sticky/multiple-layers-sticky-crash.html

    r155608 r244353  
    1313
    1414    div {
    15       position: -webkit-sticky;
     15      position: sticky;
    1616    }
    1717  </style>

  • trunk/LayoutTests/fast/css/sticky/parsing-position-sticky-expected.txt

    r187813 r244353  
    1 This tests checks that the -webkit-sticky value for position parses correctly.
     1This tests checks that the sticky value for position parses correctly.
    22
    33On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    … …  
    55
    66PASS test("position: -webkit-sticky;") is "-webkit-sticky"
    7 PASS test("position: sticky;") is ""
     7PASS test("position: sticky;") is "sticky"
    88PASS successfullyParsed is true
    99

  • trunk/LayoutTests/fast/css/sticky/remove-inline-sticky-crash.html

    r127301 r244353  
    1515
    1616    .sticky {
    17         position: -webkit-sticky;
     17        position: sticky;
    1818        top: 100px;
    1919        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/remove-sticky-crash.html

    r180441 r244353  
    1515
    1616    .sticky {
    17         position: -webkit-sticky;
     17        position: sticky;
    1818        top: 100px;
    1919        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/replaced-sticky.html

    r180441 r244353  
    3030    .sticky {
    3131        background-color: silver;
    32         position: -webkit-sticky;
     32        position: sticky;
    3333        top: 100px;
    3434    }

  • trunk/LayoutTests/fast/css/sticky/resources/parsing-position-sticky.js

    r187813 r244353  
    1 description("This tests checks that the -webkit-sticky value for position parses correctly.");
     1description("This tests checks that the sticky value for position parses correctly.");
    22
    33function test(value)
    … …  
    1313
    1414shouldBe('test("position: -webkit-sticky;")', '"-webkit-sticky"');
    15 shouldBeEqualToString('test("position: sticky;")', '');
     15shouldBe('test("position: sticky;")', '"sticky"');

  • trunk/LayoutTests/fast/css/sticky/sticky-as-positioning-container.html

    r180441 r244353  
    2929
    3030    .sticky {
    31         position: -webkit-sticky;
     31        position: sticky;
    3232        top: 100px;
    3333        background-color: silver;

  • trunk/LayoutTests/fast/css/sticky/sticky-both-sides.html

    r180441 r244353  
    3636
    3737    .sticky {
    38         position: -webkit-sticky;
     38        position: sticky;
    3939        left: 50px;
    4040        right: 50px;

  • trunk/LayoutTests/fast/css/sticky/sticky-bottom-overflow-padding.html

    r164324 r244353  
    3636
    3737    .sticky {
    38         position: -webkit-sticky;
     38        position: sticky;
    3939        bottom: 0px;
    4040        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/sticky-left-percentage.html

    r180441 r244353  
    2828
    2929    .sticky {
    30         position: -webkit-sticky;
     30        position: sticky;
    3131        /* DRT window is 800px wide */
    3232        left: 12.5%;

  • trunk/LayoutTests/fast/css/sticky/sticky-left.html

    r180441 r244353  
    2828
    2929    .sticky {
    30         position: -webkit-sticky;
     30        position: sticky;
    3131        left: 100px;
    3232        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/sticky-margins.html

    r180441 r244353  
    3030
    3131    .sticky {
    32         position: -webkit-sticky;
     32        position: sticky;
    3333        top: 10px;
    3434        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/sticky-overflowing.html

    r180441 r244353  
    4747
    4848    .sticky {
    49         position: -webkit-sticky;
     49        position: sticky;
    5050        top: 200px;
    5151        right: 200px;

  • trunk/LayoutTests/fast/css/sticky/sticky-side-margins.html

    r180441 r244353  
    2828
    2929    .sticky {
    30         position: -webkit-sticky;
     30        position: sticky;
    3131        left: 100px;
    3232        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/sticky-stacking-context-expected.html

    r180441 r244353  
    2020
    2121    .sticky {
    22         position: -webkit-sticky;
     22        position: sticky;
    2323    }
    2424   

  • trunk/LayoutTests/fast/css/sticky/sticky-stacking-context.html

    r180441 r244353  
    1919
    2020    .sticky {
    21         position: -webkit-sticky;
     21        position: sticky;
    2222    }
    2323   

  • trunk/LayoutTests/fast/css/sticky/sticky-table-row-top.html

    r162960 r244353  
    3636
    3737    .sticky {
    38         position: -webkit-sticky;
     38        position: sticky;
    3939        top: 100px;
    4040        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/sticky-table-thead-top.html

    r162960 r244353  
    3636
    3737    .sticky {
    38         position: -webkit-sticky;
     38        position: sticky;
    3939        top: 100px;
    4040        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/sticky-top-margins.html

    r180441 r244353  
    3030
    3131    .sticky {
    32         position: -webkit-sticky;
     32        position: sticky;
    3333        top: 10px;
    3434        margin: 20px;

  • trunk/LayoutTests/fast/css/sticky/sticky-top-overflow-container-overflow.html

    r152998 r244353  
    3535
    3636    .sticky {
    37         position: -webkit-sticky;
     37        position: sticky;
    3838        top: 100px;
    3939        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/sticky-top-overflow.html

    r180441 r244353  
    3535
    3636    .sticky {
    37         position: -webkit-sticky;
     37        position: sticky;
    3838        top: 100px;
    3939        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/sticky-top-zoomed-expected.html

    r138036 r244353  
    3333
    3434    .sticky {
    35         position: -webkit-sticky;
     35        position: sticky;
    3636        top: 75px;
    3737        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/sticky-top-zoomed.html

    r138036 r244353  
    3333
    3434    .sticky {
    35         position: -webkit-sticky;
     35        position: sticky;
    3636        top: 75px;
    3737        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/sticky-top.html

    r180441 r244353  
    2929
    3030    .sticky {
    31         position: -webkit-sticky;
     31        position: sticky;
    3232        top: 100px;
    3333        background-color: green;

  • trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-horizontal-bt.html

    r180441 r244353  
    3131
    3232    .sticky {
    33         position: -webkit-sticky;
     33        position: sticky;
    3434        top: 100px;
    3535        bottom: 100px;

  • trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-lr.html

    r180441 r244353  
    3030
    3131    .sticky {
    32         position: -webkit-sticky;
     32        position: sticky;
    3333        background-color: green;
    3434        width: 100px;

  • trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-rl.html

    r180441 r244353  
    3030
    3131    .sticky {
    32         position: -webkit-sticky;
     32        position: sticky;
    3333        background-color: green;
    3434        width: 100px;

  • trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html

    r169160 r244353  
    1919    style = document.createElement("style");
    2020    style.innerHTML = "* { \n\
    21         position: -webkit-sticky;\n\
     21        position: sticky;\n\
    2222        -webkit-animation-direction: alternate-reverse;";
    2323

  • trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive.html

    r244228 r244353  
    2020      }
    2121      .sticky {
    22          position: -webkit-sticky;
    2322         position: sticky;
    2423         height: 100px;

  • trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2.html

    r200116 r244353  
    1212This test makes sure that position-sticky obeys RTL scrollbars when positioning.
    1313<div style="position: absolute; top: 100px; left: 0px; width: 2000px; height: 2000px;">
    14     <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
     14    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
    1515</div>
    1616<script>

  • trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document.html

    r200116 r244353  
    1212This test makes sure that position-sticky obeys RTL scrollbars when positioning.
    1313<div style="position: absolute; top: 100px; left: 0px; width: 2000px; height: 2000px;">
    14     <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
     14    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
    1515</div>
    1616</body>

  • trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2.html

    r200116 r244353  
    1616<body>
    1717<div style='position: absolute; top: 0px; left: 0px; width: 2000px; height: 2000px'>
    18     <div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div><div style='display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;'></div><div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div>
     18    <div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div><div style='display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;'></div><div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div>
    1919</div>
    2020<script>

  • trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe.html

    r200116 r244353  
    1616<body>
    1717<div style='position: absolute; top: 0px; left: 0px; width: 2000px; height: 2000px'>
    18     <div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div><div style='display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;'></div><div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div>
     18    <div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div><div style='display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;'></div><div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div>
    1919</div>
    2020</body>

  • trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html

    r200116 r244353  
    1313<div id="scrolling" style="position: relative; width: 600px; height: 500px; overflow: scroll;">
    1414<div style="position: absolute; top: 0px; left: 0px; width: 2000px;">
    15     <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
     15    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
    1616</div>
    1717</div>

  • trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html

    r200116 r244353  
    1313<div style="position: relative; width: 600px; height: 500px; overflow: scroll;">
    1414<div style="position: absolute; top: 0px; left: 0px; width: 2000px;">
    15     <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
     15    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
    1616</div>
    1717</div>

  • trunk/LayoutTests/fast/scrolling/sticky-to-fixed.html

    r206712 r244353  
    77}
    88.masthead {
    9     position: -webkit-sticky;
     9    position: sticky;
    1010    width: 200px;
    1111    height: 100px;

  • trunk/LayoutTests/legacy-animation-engine/fast/multicol/newmulticol/table-section-crash.html

    r230471 r244353  
    1919    style = document.createElement("style");
    2020    style.innerHTML = "* { \n\
    21         position: -webkit-sticky;\n\
     21        position: sticky;\n\
    2222        -webkit-animation-direction: alternate-reverse;";
    2323

  • trunk/LayoutTests/scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html

    r244228 r244353  
    2424        }
    2525        .sticky {
    26             position: -webkit-sticky;
     26            position: sticky;
    2727            top: 10px;
    2828            bottom: 10px;

  • trunk/LayoutTests/svg/text/select-text-inside-non-static-position.html

    r160819 r244353  
    44<style>
    55* {
    6     position: -webkit-sticky;
     6    position: sticky;
    77    -webkit-transform: scaleX(2);
    88}

  • trunk/LayoutTests/tiled-drawing/scrolling/sticky/negative-scroll-offset.html

    r187905 r244353  
    77
    88      .sticky {
    9         position: -webkit-sticky;
     9        position: sticky;
    1010        width: 100%;
    1111        height: 50px;

  • trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-horizontal.html

    r187905 r244353  
    2525   
    2626    .sticky {
    27       position: -webkit-sticky;
     27      position: sticky;
    2828      display: inline-block;
    2929      background: silver;

  • trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-layers.html

    r187905 r244353  
    2525   
    2626    .sticky {
    27       position: -webkit-sticky;
     27      position: sticky;
    2828      display: inline-block;
    2929      background: silver;

  • trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-vertical.html

    r187905 r244353  
    2020    .sticky {
    2121      float: left;
    22       position: -webkit-sticky;
     22      position: sticky;
    2323      background: silver;
    2424      margin: 5px;

  • trunk/Source/WebCore/ChangeLog

    r244331 r244353  
     12019-04-16  Devin Rousso  <drousso@apple.com>
     2
     3        Unprefix -webkit-sticky
     4        https://bugs.webkit.org/show_bug.cgi?id=196962
     5        <rdar://problem/40903458>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Updated existing tests.
     10
     11        This change doesn't modify functionality, only exposing a new unprefixed CSS value.
     12
     13        * css/CSSProperties.json:
     14        * css/CSSValueKeywords.in:
     15
     16        * css/CSSPrimitiveValueMappings.h:
     17        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     18        (WebCore::CSSPrimitiveValue::operator PositionType const):
     19
     20        * css/parser/CSSParserFastPaths.cpp:
     21        (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     22
     23        * editing/EditingStyle.cpp:
     24        (WebCore::EditingStyle::convertPositionStyle):
     25
    1262019-04-16  Commit Queue  <commit-queue@webkit.org>
    227

  • trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h

    r244036 r244353  
    23362336        break;
    23372337    case PositionType::Sticky:
    2338         m_value.valueID = CSSValueWebkitSticky;
     2338        m_value.valueID = CSSValueSticky;
    23392339        break;
    23402340    }
    … …  
    23542354    case CSSValueFixed:
    23552355        return PositionType::Fixed;
     2356    case CSSValueSticky:
    23562357    case CSSValueWebkitSticky:
    23572358        return PositionType::Sticky;

  • trunk/Source/WebCore/css/CSSProperties.json

    r244036 r244353  
    35023502                "fixed",
    35033503                {
     3504                    "value": "sticky",
     3505                    "url": "https://www.w3.org/TR/css-position-3/#valdef-position-sticky"
     3506                },
     3507                {
    35043508                    "value": "-webkit-sticky",
    3505                     "status": "experimental",
    3506                     "url": "https://www.w3.org/TR/css-position-3/#valdef-position-sticky"
     3509                    "status": "deprecated"
    35073510                }
    35083511            ],

  • trunk/Source/WebCore/css/CSSValueKeywords.in

    r244036 r244353  
    11541154
    11551155// position
     1156sticky
    11561157-webkit-sticky
    11571158

  • trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp

    r244036 r244353  
    628628        return valueID == CSSValueVisible || valueID == CSSValueNone || valueID == CSSValueAll || valueID == CSSValueAuto || (valueID >= CSSValueVisiblePainted && valueID <= CSSValueStroke);
    629629    case CSSPropertyPosition: // static | relative | absolute | fixed | sticky
    630         return valueID == CSSValueStatic || valueID == CSSValueRelative || valueID == CSSValueAbsolute || valueID == CSSValueFixed || valueID == CSSValueWebkitSticky;
     630        return valueID == CSSValueStatic
     631            || valueID == CSSValueRelative
     632            || valueID == CSSValueAbsolute
     633            || valueID == CSSValueFixed
     634            || valueID == CSSValueSticky || valueID == CSSValueWebkitSticky;
    631635    case CSSPropertyResize: // none | both | horizontal | vertical | auto
    632636        return valueID == CSSValueNone || valueID == CSSValueBoth || valueID == CSSValueHorizontal || valueID == CSSValueVertical || valueID == CSSValueAuto;

  • trunk/Source/WebCore/editing/EditingStyle.cpp

    r243163 r244353  
    13901390
    13911391    auto& cssValuePool = CSSValuePool::singleton();
    1392     RefPtr<CSSPrimitiveValue> sticky = cssValuePool.createIdentifierValue(CSSValueWebkitSticky);
     1392    RefPtr<CSSPrimitiveValue> sticky = cssValuePool.createIdentifierValue(CSSValueSticky);
    13931393    if (m_mutableStyle->propertyMatches(CSSPropertyPosition, sticky.get())) {
    13941394        m_mutableStyle->setProperty(CSSPropertyPosition, cssValuePool.createIdentifierValue(CSSValueStatic), m_mutableStyle->propertyIsImportant(CSSPropertyPosition));

  • trunk/Source/WebInspectorUI/ChangeLog

    r244351 r244353  
     12019-04-16  Devin Rousso  <drousso@apple.com>
     2
     3        Unprefix -webkit-sticky
     4        https://bugs.webkit.org/show_bug.cgi?id=196962
     5        <rdar://problem/40903458>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Replace all `-webkit-sticky` with `sticky`.
     10
     11        * UserInterface/Models/CSSKeywordCompletions.js:
     12        * UserInterface/Views/AuditTestCaseContentView.css:
     13        (.content-view-container > .content-view.audit-test-case > header):
     14        * UserInterface/Views/AuditTestGroupContentView.css:
     15        (.content-view.audit-test-group.contains-test-case > header):
     16        * UserInterface/Views/ChangesDetailsSidebarPanel.css:
     17        (.changes-panel .resource-section > .header):
     18        * UserInterface/Views/DetailsSection.css:
     19        (.details-section > .header):
     20        * UserInterface/Views/NetworkDetailView.css:
     21        (.network-detail .navigation-bar):
     22        * UserInterface/Views/SettingsTabContentView.css:
     23        (.content-view.settings .navigation-bar):
     24        * UserInterface/Views/Table.css:
     25        (.table > .header):
     26
    1272019-04-16  Devin Rousso  <drousso@apple.com>
    228

  • trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js

    r243819 r244353  
    11331133    ],
    11341134    "position": [
    1135         "absolute", "fixed", "relative", "static", "-webkit-sticky",
     1135        "absolute", "fixed", "relative", "static", "sticky", "-webkit-sticky",
    11361136    ],
    11371137    "resize": [

  • trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.css

    r238333 r244353  
    2525
    2626.content-view-container > .content-view.audit-test-case > header {
    27     position: -webkit-sticky;
     27    position: sticky;
    2828    top: -1px;
    2929    z-index: var(--z-index-header);

  • trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css

    r242604 r244353  
    4444
    4545.content-view.audit-test-group.contains-test-case > header {
    46     position: -webkit-sticky;
     46    position: sticky;
    4747    top: -1px;
    4848    z-index: var(--z-index-header);

  • trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.css

    r243038 r244353  
    5252
    5353.changes-panel .resource-section > .header {
    54     position: -webkit-sticky;
     54    position: sticky;
    5555    top: 0;
    5656    z-index: var(--z-index-header);

  • trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css

    r243180 r244353  
    4444
    4545.details-section > .header {
    46     position: -webkit-sticky;
     46    position: sticky;
    4747    top: -1px;
    4848    height: 23px;

  • trunk/Source/WebInspectorUI/UserInterface/Views/NetworkDetailView.css

    r242118 r244353  
    3636
    3737.network-detail .navigation-bar {
    38     position: -webkit-sticky;
     38    position: sticky;
    3939    top: 0;
    4040    z-index: 1;

  • trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css

    r242768 r244353  
    3131
    3232.content-view.settings .navigation-bar {
    33     position: -webkit-sticky;
     33    position: sticky;
    3434    top: 0;
    3535    z-index: 1;

  • trunk/Source/WebInspectorUI/UserInterface/Views/Table.css

    r239760 r244353  
    3636
    3737.table > .header {
    38     position: -webkit-sticky;
     38    position: sticky;
    3939    top: 0;
    4040    height: var(--navigation-bar-height);
Note: See TracChangeset for help on using the changeset viewer.