Changeset 244461 in webkit

Timestamp:

Apr 19, 2019 12:33:23 PM (5 years ago)

Author:

rniwa@webkit.org

Message:

REGRESSION: (r244182) Layout Test editing/execCommand/insert-nested-lists.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=196985

Reviewed by Wenson Hsieh.

The flakiness was caused by the test incorrectly assuming that rAF would
be enough to close the undo group in the UI process.

Fixed the test by explicitly waiting for the runloop in the ui process to run
by executing a UI script.

• editing/execCommand/insert-nested-lists.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• editing/execCommand/insert-nested-lists.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-04-19  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION: (r244182) Layout Test editing/execCommand/insert-nested-lists.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=196985
+
+        Reviewed by Wenson Hsieh.
+
+        The flakiness was caused by the test incorrectly assuming that rAF would
+        be enough to close the undo group in the UI process.
+
+        Fixed the test by explicitly waiting for the runloop in the ui process to run
+        by executing a UI script.
+
+        * editing/execCommand/insert-nested-lists.html:
+
 2019-04-18  Megan Gardner  <megan_gardner@apple.com>
 

trunk/LayoutTests/editing/execCommand/insert-nested-lists.html

@@ -24 +24 @@
     // By default, AppKit on macOS coalesces undo operations that occur within the same runloop. Wait until the next
     // runloop before inserting another unordered list to ensure that it gets its own entry in the undo stack.
-    await new Promise(resolve => requestAnimationFrame(resolve));
+    await new Promise((resolve) => {
+        if (window.testRunner)
+            testRunner.runUIScript(`(function() { uiController.uiScriptComplete(); })()`, resolve);
+        else
+            setTimeout(resolve, 500);
+    });
 
     document.execCommand("InsertNestedUnorderedList");