Changeset 244498 in webkit


Ignore:
Timestamp:
Apr 22, 2019 12:58:11 AM (5 years ago)
Author:
Carlos Garcia Campos
Message:

REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=194630

Reviewed by Michael Catanzaro.

Source/WebCore:

Do not assume core object always has a wrapper in webkitAccessibleRefChild().

Fixes: accessibility/removed-continuation-element-causes-crash.html

accessibility/removed-anonymous-block-child-causes-crash.html

  • accessibility/atk/WebKitAccessible.cpp:

(webkitAccessibleRefChild): Return early if wrapper is nullptr.

Tools:

Return early from getAttributeSet() is passed in accessible is nullptr.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Remove expectations for tests that are passing now.

  • platform/gtk/TestExpectations:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r244491 r244498  
     12019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
     4        https://bugs.webkit.org/show_bug.cgi?id=194630
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Remove expectations for tests that are passing now.
     9
     10        * platform/gtk/TestExpectations:
     11
    1122019-04-20  Said Abou-Hallawa  <said@apple.com>
    213

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r244329 r244498  
    13221322webkit.org/b/191882 fast/forms/validation-message-in-relative-body.html [ Failure Crash ]
    13231323
    1324 webkit.org/b/194630 accessibility/removed-anonymous-block-child-causes-crash.html [ Crash ]
    1325 webkit.org/b/194630 accessibility/removed-continuation-element-causes-crash.html [ Crash ]
    1326 
    13271324webkit.org/b/195260 mathml/presentation/tokenElements-dynamic.html [ Crash Pass ]
    13281325

  • trunk/Source/WebCore/ChangeLog

    r244495 r244498  
     12019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
     4        https://bugs.webkit.org/show_bug.cgi?id=194630
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Do not assume core object always has a wrapper in webkitAccessibleRefChild().
     9
     10        Fixes: accessibility/removed-continuation-element-causes-crash.html
     11               accessibility/removed-anonymous-block-child-causes-crash.html
     12
     13        * accessibility/atk/WebKitAccessible.cpp:
     14        (webkitAccessibleRefChild): Return early if wrapper is nullptr.
     15
    1162019-04-21  Darin Adler  <darin@apple.com>
    217

  • trunk/Source/WebCore/accessibility/atk/WebKitAccessible.cpp

    r244187 r244498  
    349349        return nullptr;
    350350
    351     auto* child = ATK_OBJECT(coreChild->wrapper());
    352     atk_object_set_parent(child, object);
    353     g_object_ref(child);
    354 
    355     return child;
     351    auto* child = coreChild->wrapper();
     352    if (!child)
     353        return nullptr;
     354
     355    atk_object_set_parent(ATK_OBJECT(child), object);
     356    return ATK_OBJECT(g_object_ref(child));
    356357}
    357358

  • trunk/Tools/ChangeLog

    r244494 r244498  
     12019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
     4        https://bugs.webkit.org/show_bug.cgi?id=194630
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Return early from getAttributeSet() is passed in accessible is nullptr.
     9
     10        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
     11
    1122019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
    213

  • trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

    r244073 r244498  
    185185AtkAttributeSet* getAttributeSet(AtkObject* accessible, AtkAttributeType type)
    186186{
     187    if (!accessible)
     188        return nullptr;
     189
    187190    if (type == ObjectAttributeType)
    188191        return atk_object_get_attributes(accessible);
Note: See TracChangeset for help on using the changeset viewer.