Changeset 244504 in webkit

Timestamp:

Apr 22, 2019 11:29:40 AM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] Use singular verb in failure description in case of single api test failure
​https://bugs.webkit.org/show_bug.cgi?id=197013

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeAPITestsResults.analyzeResults):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -808 +808 @@
             self.finished(FAILURE)
             self.build.results = FAILURE
-            message = 'Found {} new API Tests failures: {}'.format(len(new_failures), new_failures_string)
+            pluralSuffix = 's' if len(new_failures) > 1 else ''
+            message = 'Found {} new API Test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
             self.descriptionDone = message
             self.build.buildFinished([message], FAILURE)
@@ -816 +817 @@
             self.build.results = SUCCESS
             self.descriptionDone = 'Passed API tests'
-            message = 'Found {} pre-existing API tests failures'.format(len(clean_tree_failures))
+            pluralSuffix = 's' if len(clean_tree_failures) > 1 else ''
+            message = 'Found {} pre-existing API test failure{}'.format(len(clean_tree_failures), pluralSuffix)
             if flaky_failures:
                 message += '. Flaky tests: {}'.format(flaky_failures_string)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-22  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Use singular verb in failure description in case of single api test failure
+        https://bugs.webkit.org/show_bug.cgi?id=197013
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (AnalyzeAPITestsResults.analyzeResults):
+
 2019-04-22  Chris Dumez  <cdumez@apple.com>