Changeset 244529 in webkit

Timestamp:

Apr 22, 2019 5:15:03 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Deprecate WKContextCreateWithInjectedBundlePath
​https://bugs.webkit.org/show_bug.cgi?id=197169

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-04-22
Reviewed by Youenn Fablet.

Source/WebKit:

• UIProcess/API/C/WKContext.h:

Tools:

• TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextWithInjectedBundle):
Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/API/C/WKContext.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/PlatformUtilities.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-22  Alex Christensen  <achristensen@webkit.org>
+
+        Deprecate WKContextCreateWithInjectedBundlePath
+        https://bugs.webkit.org/show_bug.cgi?id=197169
+
+        Reviewed by Youenn Fablet.
+
+        * UIProcess/API/C/WKContext.h:
+
 2019-04-22  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/API/C/WKContext.h

@@ -108 +108 @@
 
 WK_EXPORT WKContextRef WKContextCreate() WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKContextCreateWithConfiguration);
-WK_EXPORT WKContextRef WKContextCreateWithInjectedBundlePath(WKStringRef path);
+WK_EXPORT WKContextRef WKContextCreateWithInjectedBundlePath(WKStringRef path) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKContextCreateWithConfiguration);
 WK_EXPORT WKContextRef WKContextCreateWithConfiguration(WKContextConfigurationRef configuration);
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-22  Alex Christensen  <achristensen@webkit.org>
+
+        Deprecate WKContextCreateWithInjectedBundlePath
+        https://bugs.webkit.org/show_bug.cgi?id=197169
+
+        Reviewed by Youenn Fablet.
+
+        * TestWebKitAPI/PlatformUtilities.cpp:
+        (TestWebKitAPI::Util::createContextWithInjectedBundle):
+        Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
+
 2019-04-22  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/TestWebKitAPI/PlatformUtilities.cpp

@@ -27 +27 @@
 #include "PlatformUtilities.h"
 
+#include <WebKit/WKContextConfigurationRef.h>
 #include <wtf/StdLibExtras.h>
 
@@ -37 +38 @@
 {
     WKRetainPtr<WKStringRef> injectedBundlePath = adoptWK(createInjectedBundlePath());
-    WKContextRef context = WKContextCreateWithInjectedBundlePath(injectedBundlePath.get());
-
-    return context;
+    auto configuration = adoptWK(WKContextConfigurationCreate());
+    WKContextConfigurationSetInjectedBundlePath(configuration.get(), injectedBundlePath.get());
+    return WKContextCreateWithConfiguration(configuration.get());
 }