Changeset 244547 in webkit

Timestamp:

Apr 23, 2019 10:51:55 AM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Exception while loading status-bubble when no build step has started
​https://bugs.webkit.org/show_bug.cgi?id=196676

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -131 +131 @@
 
     def get_build_timestamp(self, build):
-        if not build.complete_at:  # In-progress build
-            return self._iso_time(build.step_set.last().started_at)
-        return self._iso_time(build.complete_at)
+        if build.complete_at:
+            return self._iso_time(build.complete_at)
+
+        recent_build_step = build.step_set.last()
+        if recent_build_step:
+            return self._iso_time(recent_build_step.started_at)
+
+        return self._iso_time(build.started_at)
 
     def _iso_time(self, time):

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-23  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Exception while loading status-bubble when no build step has started
+        https://bugs.webkit.org/show_bug.cgi?id=196676
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
+
 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>