Changeset 244581 in webkit


Ignore:
Timestamp:
Apr 23, 2019 9:16:30 PM (5 years ago)
Author:
wilander@apple.com
Message:

Move Ad Click Attribution from internal feature to experimental feature
​https://bugs.webkit.org/show_bug.cgi?id=197218
<rdar://problem/47651691>

Reviewed by Brent Fulgham.

Source/WebKit:

  • Shared/WebPreferences.yaml:

Tools:

  • DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):

LayoutTests:

This patch removes the TestRunner instruction for turning on the internal
feature.

  • http/tests/adClickAttribution/anchor-tag-attributes-validation.html:
  • http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html:
  • http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html:
  • http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html:
  • http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html:
  • http/tests/adClickAttribution/second-conversion-with-higher-priority.html:
  • http/tests/adClickAttribution/second-conversion-with-lower-priority.html:
  • http/tests/adClickAttribution/send-attribution-conversion-request.html:
  • http/tests/adClickAttribution/store-ad-click-attribution.html:
  • http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html:
  • http/tests/contentextensions/block-ad-click-attribution.html:
Location:
trunk
Files:
16 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r244572 r244581  
     12019-04-23  John Wilander  <wilander@apple.com>
     2
     3        Move Ad Click Attribution from internal feature to experimental feature
     4        https://bugs.webkit.org/show_bug.cgi?id=197218
     5        <rdar://problem/47651691>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        This patch removes the TestRunner instruction for turning on the internal
     10        feature.
     11
     12        * http/tests/adClickAttribution/anchor-tag-attributes-validation.html:
     13        * http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html:
     14        * http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html:
     15        * http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html:
     16        * http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html:
     17        * http/tests/adClickAttribution/second-conversion-with-higher-priority.html:
     18        * http/tests/adClickAttribution/second-conversion-with-lower-priority.html:
     19        * http/tests/adClickAttribution/send-attribution-conversion-request.html:
     20        * http/tests/adClickAttribution/store-ad-click-attribution.html:
     21        * http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html:
     22        * http/tests/contentextensions/block-ad-click-attribution.html:
     23
    1242019-04-23  John Wilander  <wilander@apple.com>
    225

  • trunk/LayoutTests/http/tests/adClickAttribution/anchor-tag-attributes-validation.html

    r241490 r244581  
    1 <!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true, internal:AdClickAttributionEnabled=true ] -->
     1<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
    22<html lang="en">
    33<head>

  • trunk/LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html

    r244475 r244581  
    1 <!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
     1<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
    22<html lang="en">
    33<head>

  • trunk/LayoutTests/http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html

    r244475 r244581  
    1 <!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
     1<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
    22<html lang="en">
    33<head>

  • trunk/LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html

    r244475 r244581  
    1 <!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
     1<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
    22<html lang="en">
    33<head>

  • trunk/LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html

    r244475 r244581  
    1 <!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
     1<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
    22<html lang="en">
    33<head>

  • trunk/LayoutTests/http/tests/adClickAttribution/second-conversion-with-higher-priority.html

    r244475 r244581  
    1 <!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
     1<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
    22<html lang="en">
    33<head>

  • trunk/LayoutTests/http/tests/adClickAttribution/second-conversion-with-lower-priority.html

    r244475 r244581  
    1 <!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
     1<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
    22<html lang="en">
    33<head>

  • trunk/LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html

    r244475 r244581  
    1 <!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
     1<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
    22<html lang="en">
    33<head>

  • trunk/LayoutTests/http/tests/adClickAttribution/store-ad-click-attribution.html

    r244475 r244581  
    1 <!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
     1<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
    22<html lang="en">
    33<head>

  • trunk/LayoutTests/http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html

    r244475 r244581  
    1 <!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
     1<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
    22<html lang="en">
    33<head>

  • trunk/LayoutTests/http/tests/contentextensions/block-ad-click-attribution.html

    r244544 r244581  
    1 <!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
     1<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
    22<html lang="en">
    33<head>

  • trunk/Source/WebKit/ChangeLog

    r244575 r244581  
     12019-04-23  John Wilander  <wilander@apple.com>
     2
     3        Move Ad Click Attribution from internal feature to experimental feature
     4        https://bugs.webkit.org/show_bug.cgi?id=197218
     5        <rdar://problem/47651691>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        * Shared/WebPreferences.yaml:
     10
    1112019-04-23  Keith Rollin  <krollin@apple.com>
    212

  • trunk/Source/WebKit/Shared/WebPreferences.yaml

    r244428 r244581  
    14051405  condition: ENABLE(RESIZE_OBSERVER)
    14061406
     1407AdClickAttributionEnabled:
     1408    type: bool
     1409    defaultValue: false
     1410    humanReadableName: "Ad Click Attribution"
     1411    humanReadableDescription: "Enable Ad Click Attribution for Cross-Site Link Navigations"
     1412    webcoreBinding: RuntimeEnabledFeatures
     1413    category: experimental
     1414
    14071415# For internal features:
    14081416# The type should be boolean.
    … …  
    16031611  category: internal
    16041612
    1605 AdClickAttributionEnabled:
    1606   type: bool
    1607   defaultValue: false
    1608   humanReadableName: "Ad Click Attribution"
    1609   humanReadableDescription: "Enable Ad Click Attribution for Cross-Site Link Navigations"
    1610   webcoreBinding: RuntimeEnabledFeatures
    1611   category: internal
    1612 
    16131613DOMPasteAccessRequestsEnabled:
    16141614  type: bool

  • trunk/Tools/ChangeLog

    r244573 r244581  
     12019-04-23  John Wilander  <wilander@apple.com>
     2
     3        Move Ad Click Attribution from internal feature to experimental feature
     4        https://bugs.webkit.org/show_bug.cgi?id=197218
     5        <rdar://problem/47651691>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        * DumpRenderTree/TestOptions.cpp:
     10        (TestOptions::TestOptions):
     11
    1122019-04-23  Andy Estes  <aestes@apple.com>
    213

  • trunk/Tools/DumpRenderTree/TestOptions.cpp

    r243643 r244581  
    110110        else if (key == "internal:CSSLogicalEnabled")
    111111            enableCSSLogical = parseBooleanTestHeaderValue(value);
    112         else if (key == "internal:AdClickAttributionEnabled")
     112        else if (key == "experimental:AdClickAttributionEnabled")
    113113            adClickAttributionEnabled = parseBooleanTestHeaderValue(value);
    114114        else if (key == "experimental:ResizeObserverEnabled")
Note: See TracChangeset for help on using the changeset viewer.