Changeset 244613 in webkit


Ignore:
Timestamp:
Apr 24, 2019 2:27:46 PM (5 years ago)
Author:
Chris Dumez
Message:

Fix flaky crashes in a couple of PSON API tests
https://bugs.webkit.org/show_bug.cgi?id=197239

Reviewed by Tim Horton.

Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r244599 r244613  
     12019-04-24  Chris Dumez  <cdumez@apple.com>
     2
     3        Fix flaky crashes in a couple of PSON API tests
     4        https://bugs.webkit.org/show_bug.cgi?id=197239
     5
     6        Reviewed by Tim Horton.
     7
     8        Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
     9
     10        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
     11
    1122019-04-24  Simon Fraser  <simon.fraser@apple.com>
    213
  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm

    r244540 r244613  
    59155915    [webView setUIDelegate: uiDelegate.get()];
    59165916
    5917     auto request = adoptNS([NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.webkit.org/getUserMedia.html"]]);
    5918     [webView loadRequest:request.get()];
     5917    auto request = [NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.webkit.org/getUserMedia.html"]];
     5918    [webView loadRequest:request];
    59195919
    59205920    TestWebKitAPI::Util::run(&done);
     
    59255925    auto pid1 = [webView _webProcessIdentifier];
    59265926
    5927     request = adoptNS([NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.apple.org/test.html"]]);
    5928     [webView loadRequest:request.get()];
     5927    request = [NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.apple.org/test.html"]];
     5928    [webView loadRequest:request];
    59295929
    59305930    TestWebKitAPI::Util::run(&done);
     
    59815981    [webView setNavigationDelegate:navigationDelegate.get()];
    59825982
    5983     auto request = adoptNS([NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.webkit.org/page-overlay"]]);
    5984     [webView loadRequest:request.get()];
     5983    auto request = [NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.webkit.org/page-overlay"]];
     5984    [webView loadRequest:request];
    59855985
    59865986    TestWebKitAPI::Util::run(&done);
     
    59955995#endif
    59965996
    5997     request = adoptNS([NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.apple.com/page-overlay"]]);
    5998     [webView loadRequest:request.get()];
     5997    request = [NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.apple.com/page-overlay"]];
     5998    [webView loadRequest:request];
    59995999
    60006000    TestWebKitAPI::Util::run(&done);
Note: See TracChangeset for help on using the changeset viewer.