Changeset 244674 in webkit


Ignore:
Timestamp:
Apr 25, 2019 6:58:33 PM (5 years ago)
Author:
sihui_liu@apple.com
Message:

[ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=196357
<rdar://problem/49386836>

Reviewed by Geoffrey Garen.

Source/WebCore:

Dispatch IDBRequest event to IDBTransaction if event of IDBTransaction has not been dispatched.

Covered by existing tests.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::dispatchEvent):

  • Modules/indexeddb/IDBTransaction.h:

LayoutTests:

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r244661 r244674  
     12019-04-25  Sihui Liu  <sihui_liu@apple.com>
     2
     3        [ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=196357
     5        <rdar://problem/49386836>
     6
     7        Reviewed by Geoffrey Garen.
     8
     9        * platform/ios-simulator-wk2/TestExpectations:
     10        * platform/mac-wk2/TestExpectations:
     11        * platform/mac/TestExpectations:
     12
    1132019-04-25  Shawn Roberts  <sroberts@apple.com>
    214

  • trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations

    r244650 r244674  
    7676webkit.org/b/196112 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-italic.html [ Pass ImageOnlyFailure ]
    7777
    78 webkit.org/b/196357 storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html [ Pass Failure ]
    79 
    8078http/wpt/cache-storage/quota-third-party.https.html [ Slow ]
    8179http/wpt/fetch/response-opaque-clone.html [ Slow ]

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r244651 r244674  
    674674webkit.org/b/171837 [ Debug ] http/tests/security/storage-blocking-loosened-plugin.html [ Pass Failure ]
    675675
    676 webkit.org/b/171862  storage/indexeddb/modern/idbtransaction-objectstore-failures.html [ Pass Failure ]
    677 
    678676webkit.org/b/171935 [ Sierra ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html [ Pass Failure ]
    679677

  • trunk/LayoutTests/platform/mac/TestExpectations

    r244424 r244674  
    15941594webkit.org/b/165311 [ Sierra+ ] media/modern-media-controls/pip-support/pip-support-click.html [ Pass Failure ]
    15951595
    1596 webkit.org/b/176693 storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html [ Pass Failure ]
    1597 
    15981596# User-installed font infrastructure is ony present on certain OSes.
    15991597webkit.org/b/180062 [ Sierra HighSierra ] fast/text/user-installed-fonts/disable.html [ ImageOnlyFailure ]

  • trunk/Source/WebCore/ChangeLog

    r244673 r244674  
     12019-04-25  Sihui Liu  <sihui_liu@apple.com>
     2
     3        [ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=196357
     5        <rdar://problem/49386836>
     6
     7        Reviewed by Geoffrey Garen.
     8
     9        Dispatch IDBRequest event to IDBTransaction if event of IDBTransaction has not been dispatched.
     10
     11        Covered by existing tests.
     12
     13        * Modules/indexeddb/IDBRequest.cpp:
     14        (WebCore::IDBRequest::dispatchEvent):
     15        * Modules/indexeddb/IDBTransaction.cpp:
     16        (WebCore::IDBTransaction::dispatchEvent):
     17        * Modules/indexeddb/IDBTransaction.h:
     18
    1192019-04-25  Chris Dumez  <cdumez@apple.com>
    220

  • trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp

    r244436 r244674  
    319319    if (&event == m_openDatabaseSuccessEvent)
    320320        m_openDatabaseSuccessEvent = nullptr;
    321     else if (m_transaction && !m_transaction->isFinished())
     321    else if (m_transaction && !m_transaction->didDispatchAbortOrCommit())
    322322        targets = { this, m_transaction.get(), &m_transaction->database() };
    323323

  • trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp

    r244436 r244674  
    642642
    643643    EventDispatcher::dispatchEvent({ this, m_database.ptr() }, event);
     644    m_didDispatchAbortOrCommit = true;
    644645
    645646    if (isVersionChange()) {

  • trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h

    r243887 r244674  
    147147    bool isFinishedOrFinishing() const;
    148148    bool isFinished() const { return m_state == IndexedDB::TransactionState::Finished; }
     149    bool didDispatchAbortOrCommit() const { return m_didDispatchAbortOrCommit; }
    149150
    150151    IDBClient::IDBConnectionProxy& connectionProxy();
    … …  
    262263
    263264    bool m_contextStopped { false };
     265    bool m_didDispatchAbortOrCommit { false };
    264266};
    265267
Note: See TracChangeset for help on using the changeset viewer.